Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Update the chunkd verison for the fix, and allow trailing slash uri #3140

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix(cli): Update the chunkd verison for the fix, and allow trailing slash uri #3140

merged 2 commits into from
Feb 22, 2024
+48 −25

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Feb 20, 2024 •
edited
Loading

Motivation

Currently config bundle commend fails to bundle config file due to some bugs.

  • trialling slash inside the uri might cause the failure
  • fsa.source().head() got a bug for reading macros urls.

Modification

  • updated chunkd package version include the fixs.
  • Allow both uri with or without trailing slash, so we can force the trailling slash in the future.

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@Wentao-Kuang Wentao-Kuang marked this pull request as ready for review February 20, 2024 22:07
@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner February 20, 2024 22:07
@blacha blacha added this pull request to the merge queue Feb 22, 2024
Merged via the queue into master with commit a0b3d9e Feb 22, 2024
10 checks passed
@blacha blacha deleted the fix/config-loader branch February 22, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacha blacha blacha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wentao-Kuang @blacha