-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and publish plugin #53
Comments
Having talked with Paolo
There are two options available:
|
The solution to be implemented is to update the sys path
This way the promote widget will not need to reference the entire path (with the illegal characters) |
This issue has been automatically marked as stale as there has not been any activity for sometime. The issue will be closed in 5 days if no further activity. |
As above renaming to correct poor package name was too difficult. A new version has been published using the sys.path solution above |
Background
The package name (linz-data-importer) followed the poor practise of using hyphens. This became an issue when promoting a custom widget via QT Designer to solve #47. The problem was when the python UI code was dynamical generated by PytQ5.uic.loadUi, the statement
import x from linz-data-importer.gui.x
was output. The hyphens makes this an invalid python import.To solve this, the package name was renamed to "linz_data_importer" (I note pep8 allows underscores).
Problem
The problem now however is that the plugin can not be loaded to the QGIS plugin server as part of the current repo as it will not allow versions with different names to be loaded.
Solution
It appears the only option available is to rename the plugin and start a 'new' plugin (as far as the QGIS plugin server is concerned).
The plugin will therefore need a new name.
Problems with the solution
I would prefer not to undertake the confusing step of renaming the plugin but am unaware of another solution.
Renaming the plugin will have the below negative outcomes:
Further consideration
Should the code repository be forked and renamed?
The text was updated successfully, but these errors were encountered: