We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi.
Recently I found a vulnerability in https://github.com/enumatech/secp256k1-js, the ecverify function does not check sig.r = sig.s = 0, which leads an attacker can construct a malicious signature (0, 0) that passes arbitrary checks. This is a classic attack method on ECDSA, more details can be seen at https://nakedsecurity.sophos.com/2022/04/20/critical-cryptographic-java-security-blunder-patched-update-now/.
https://github.com/enumatech/secp256k1-js
ecverify
sig.r = sig.s = 0
(0, 0)
Since I see there are also some other projects depend on this implementation, I think you might need to check and fix this vulnerability.
You can also contact me if you have any other question, best wishes.
The text was updated successfully, but these errors were encountered:
302800f
@shilohshi Thanks for this! I've added tests and the necessary validations.
Sorry, something went wrong.
No branches or pull requests
Hi.
Recently I found a vulnerability in
https://github.com/enumatech/secp256k1-js, theecverifyfunction does not checksig.r = sig.s = 0, which leads an attacker can construct a malicious signature(0, 0)that passes arbitrary checks. This is a classic attack method on ECDSA, more details can be seen at https://nakedsecurity.sophos.com/2022/04/20/critical-cryptographic-java-security-blunder-patched-update-now/.Since I see there are also some other projects depend on this implementation, I think you might need to check and fix this vulnerability.
You can also contact me if you have any other question, best wishes.
The text was updated successfully, but these errors were encountered: