Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen the canvas directly #38

Closed
lionleaf opened this issue Jul 2, 2016 · 0 comments · Fixed by #43
Closed

Fullscreen the canvas directly #38

lionleaf opened this issue Jul 2, 2016 · 0 comments · Fixed by #43

Comments

@lionleaf
Copy link
Owner

lionleaf commented Jul 2, 2016

Using fullscreen APIs to fullscreen the actual canvas instead of opening a new tab
sigvef added a commit to sigvef/dwitter that referenced this issue Jul 20, 2016
@sigvef
Use Fullscreen API for fullscreen button
e25f66f 
Non-js clients will gracefully fall back to regular old linking. A
special-case is needed in the scrolling play/pause logic, since
Waypoints.inview thinks that fullscreened elements are not inview.

This fixes lionleaf#38.
@sigvef sigvef mentioned this issue Jul 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Fullscreen API for fullscreen button sigvef/dwitter
1 participant
@lionleaf