Send message to Discord with a webhook upon dweet creation #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register a signal that triggers on new dweets that sends a POST request to the configured DISCORD_WEBHOOK (from settings/local.py) that posts a message to Discord. This commit also sets up the signals.py file and imports it with the recommended path (apps.py).
lionleaf
force-pushed
the
webhooks
branch
2 times, most recently
from
59a7c8a
to
6297a32
Compare
For some reasons reverse() is failing in the @signal on Jenkins when testing, but not while running tests locally. Seems like the signal is called before urls.py is loaded somehow, but I don't understand why that would be different locally. As the urls were partially hardcoded anyway, reverse() isn't providing a lot of value, and this text is likely to get changed later, I'm just hardcoding the full url
urllib2 is python2 only. And the default python3 equivalent doesn't work in python2. So had to install future to bridge the gap
Simpler and with python2 and 3 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register a signal that triggers on new dweets that sends a POST request
to the configured DISCORD_WEBHOOK (from settings/local.py) that posts a
message to Discord.
This commit also sets up the signals.py file and imports it with the
recommended path (apps.py).
make lintto ensure that all the files are formatted and using best practices.fixes #370