RGB loss calculation

[SherlockSunset]

Hi, just going through the rgb loss calculation part. For my understanding, it seems the highlighted part should be: l_1 loss divided by the float((object_mask).sum()), which means averge the valid number of pixels instead of also considering the pixels outside of the object mask. Hope someone can correct me if there is anything wrong, thanks.

[SherlockSunset]

Just found out that there are two cases:
one is for the fixed ground truth cameras, the mask of the image already correctly cover the captured object's valid region, for our rendering loss, we only need to care about those valid region, instead of average over the whole image size.
Another case is for the noisy camera initializations, the mask of the image may not fully cover the captured object's valid region, which means we need to apply loss over the whole image size.