Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable Sound Pack #1

Closed
9 of 10 tasks
liplum opened this issue Dec 19, 2022 · 4 comments · Fixed by #12
Closed
9 of 10 tasks

Customizable Sound Pack #1

liplum opened this issue Dec 19, 2022 · 4 comments · Fixed by #12
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@liplum
Copy link
Member

liplum commented Dec 19, 2022

Basic Support

Advanced Support

Worth Mentioning

  • Display the sound packs in alphabetical order? Or addition time? Or the frenquency user used?
  • How to save the indices of sound packs?
@liplum liplum self-assigned this Dec 19, 2022
@liplum liplum added this to the v1.0.0 milestone Dec 19, 2022
@liplum liplum added the enhancement New feature or request label Dec 19, 2022
@liplum
Copy link
Member Author

liplum commented Dec 20, 2022

How to save the indices of sound packs?

Hive is used. The index is Soundpack.id;

@liplum
Copy link
Member Author

liplum commented Dec 20, 2022

Duplicate a soundpack.

How can files be duplicated? I don't think copying lots of *.wav files is a good idea.
Maybe the Soundpack should contain a list of SoundFile, this is, a ref of a real file or in assets bundle.
When it comes to export the Soundpack, the real SoundFile will be resolved and copied lazily.

@liplum liplum linked a pull request Dec 21, 2022 that will close this issue
@liplum
Copy link
Member Author

liplum commented Dec 21, 2022

Display the sound packs in alphabetical order? Or addition time? Or the frenquency user used?

For now, when building the list view, the widget doesn't know anything about what's behind an Soundpack ID.
To optimize the performance, the Soundpack Model/Entity is only loaded while the Item widget is initialized.

@liplum
Copy link
Member Author

liplum commented Dec 22, 2022

Duplicate a soundpack.

How can files be duplicated? I don't think copying lots of *.wav files is a good idea. Maybe the Soundpack should contain a list of SoundFile, this is, a ref of a real file or in assets bundle. When it comes to export the Soundpack, the real SoundFile will be resolved and copied lazily.

It's hard to manage the reference of files, which would introduce a reference counter. So this design is removed in 231fadc.
Then, duplicating will copy all the files.
Since the soundpack is small in general, don't worry about it takes too much room.

@liplum liplum modified the milestones: v1.0.0, Alpha Test Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant