Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS/Git remote URLs not found #67

Open
jayvdb opened this issue Apr 5, 2020 · 2 comments
Open

VCS/Git remote URLs not found #67

jayvdb opened this issue Apr 5, 2020 · 2 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Apr 5, 2020

git@github.com:snowplow/snowplow-python-tracker.git is not found

This can be found at https://pypi.org/project/minimal-snowplow-tracker/

>>> import urlextract
>>> e = urlextract.urlextract_core.URLExtract()
>>> e.find_urls('git@github.com:snowplow/snowplow-python-tracker.git')
[]

A good list of sample VCS links can be found at
https://github.com/coala/git-url-parse/blob/master/test/conftest.py

@jayvdb
Copy link
Contributor Author

jayvdb commented Apr 5, 2020

Also worth noting that pip VCS branch support @ causes no result if there is no path

>>> e.find_urls(' git+https://git.foobar.com@branch ')
[]
>>> e.find_urls(' git+https://git.foobar.com/@foo ')
['git+https://git.foobar.com/@foo']

@za
Copy link
Contributor

za commented Oct 22, 2021

Hi @jayvdb or @lipoja I am interested to work on this issue.

So the expected result, we should return the git URL in this condition:

>>> e.find_urls('git@github.com:snowplow/snowplow-python-tracker.git')
['git@github.com:snowplow/snowplow-python-tracker.git']

Re: https://github.com/coala/git-url-parse/blob/master/test/conftest.py should we copy the URLs to test/unit/conftest.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants