Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add types to urlextract #113

Closed
georgettica opened this issue Dec 23, 2021 · 3 comments
Closed

add types to urlextract #113

georgettica opened this issue Dec 23, 2021 · 3 comments

Comments

@georgettica
Copy link

georgettica commented Dec 23, 2021

I tried on my repo to run mypy file.py
https://github.com/python/mypy

 error: Skipping analyzing "urlextract": module is installed, but missing library stubs or py.typed marker
 note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
@lipoja
Copy link
Owner

lipoja commented Dec 23, 2021

Hello,
that is because urlextract does not support type checking yet.
I am planning to do it, but it is not on high priority list. # PRs are welcome ;).

@georgettica
Copy link
Author

I'll see how I can learn and contribute.

If you get there before me please note it in this issue?

Thanks in advance and thanks for the warm response :)

@lipoja
Copy link
Owner

lipoja commented Dec 24, 2021

I appreciate any contribution and also reporting any issue.
It keeps me improving this library. And I am glad that there are people using it and also contributing and improving the code.

Let's agree that any of us will write a comment here once we start implementing type hints (mypy support).

Thank you!

mimi89999 added a commit to mimi89999/URLExtract that referenced this issue Jul 6, 2022
@lipoja lipoja closed this as completed in f9b995a Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants