Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation breaks when formatting is wrong #163

Closed
morkro opened this issue Jul 7, 2016 · 3 comments
Closed

Documentation breaks when formatting is wrong #163

morkro opened this issue Jul 7, 2016 · 3 comments

Comments

@morkro
Copy link

morkro commented Jul 7, 2016

Hello 👋,

it looks like the documentation is broken once a JSDoc comment has incorrect formatting.
Here are two occurrences I found:

  • If you go to this part of my documentation, you see that it stops reporting in the middle of the sentence. I assume the chevron (<atom-styles>) in my description causes this problem?
    screen shot 2016-07-07 at 11 07 50
  • The documentation for my createElement() method also stops with the description, and everything after that is left blank on the page. I also guess it's because I used probably unknown formatting of an optional parameter which also happens to accept two different types: @param {(Number|String)}.
    screen shot 2016-07-07 at 11 07 42

This makes me also think what the correct declaration of an optional parameter is, which happens to accept multiple types.

Anyway, great work! Really like this project 😀

Best,
Moritz

@lipp
Copy link
Owner

lipp commented Jul 7, 2016

@morkro Thanks for reporting! This is an html escaping thingy. JSDoc comments are allowed to contain HTML and Markdown. So the description potentially (and intentionally) contains HTML tags in string.

Could you try to wrap your tags in backticks? This hopefully instructs JSDoc to do the right thing...

PS: Happy you like Doclets!

@morkro
Copy link
Author

morkro commented Jul 7, 2016

Well TIL JSDoc comments are Markdown 😁 .
Thanks for the help, I updated all my JSDoc comments and that fixed the issue. Everything looks fresh now. 👍

@lipp
Copy link
Owner

lipp commented Jul 7, 2016

👍 Great!!! You are welcome! If you like Doclets, spread the word 😀

@lipp lipp closed this as completed Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants