-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error 413 after picuture upload in projects #356
Comments
When I upload a picture a second time (after error in dashboard) and it has the same filename, it's not uploaded after pressing save. |
The same happens in all project-types. Also after navigating back from the error page and pressing save without selected image to upload, same error message occurs. |
This image size is limited by our web server to 10M. Is this not enough? |
I think part of the issue is that the error page does not look particularly nice. I think it is an important security property that large file uploads are blocked before they even reach django. Still, it is not an ideal user experience. Maybe we can have a compromise: Increase the maximum in nginx, so we can show nicer error pages for medium-large files. Huge files could still be blocked early. |
The current limit in django is 5M, in the webserver 10M. Whereas we could increase the webserver limit, the disadvantage is that the image has to be fully uploaded before the django error is shown. The webserver error is shown directly. |
@rukala Can we close this issue? Or should we change the limits? |
I would like to re-open this issue. I think we need to increase the nginx filesize limit and then think about (i.e. write a US) how we could validate the filesize documents to be uploaded via JS, no? |
I just set the nginx filesize limit to 20mb on all a4 instances. I'm rather reluctant to increase it further as that opens the door for DDOS things/makes it easier. File size check seems to be easy, though, here is an example |
After I uploaded a too big picture in the Bürgerhaushalt process on dev I got an Error 413 page instead of an error in the dashboard.
The text was updated successfully, but these errors were encountered: