Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6963 Too many codes in 1 package #4911

Closed
philli-m opened this issue Feb 6, 2023 · 2 comments · Fixed by #4916
Closed

#6963 Too many codes in 1 package #4911

philli-m opened this issue Feb 6, 2023 · 2 comments · Fixed by #4916
Labels
Prio: Medium fixed and released with next scheduled release

Comments

@philli-m
Copy link
Contributor

philli-m commented Feb 6, 2023

URL: https://meinberlin-dev.liqd.net/dashboard/modules/burgerinnenhaushalt-3-phasen-21/download-codes/
user: admin, initiator
expected behaviour: Each code-package should contain a max. of 1.000.000 codes. The wording of the helptext should have also the right number of 1.000.000 codes per package as each package should contain a maximum of 1.000.000 codes per excel-file.
behaviour: the number in the wording of the helptext is "10.000.000" and the packages can contain more than 1.000.000 codes.
important screensize: -
device & browser: mac ff
Comment/Question: I tried it with generating two mill codes and the codes were put in only one code-package. I also couldn't download the package probably because it was too big.

Linked: #4907

@philli-m
Copy link
Contributor Author

philli-m commented Feb 6, 2023

@Rineee @fuzzylogic2000 is this due to here:

PACKAGE_SIZE = 10000000

if so it seems deliberate, is this just relic from our old token system or is there a reason?

@fuzzylogic2000
Copy link
Contributor

@phillimorland Yes, seems to be from that number. It was changed from slicing the packages directly in the export view to where you found it now. eacd22c
Hopefully it works again, when you remove one zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Medium fixed and released with next scheduled release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants