Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sm 2021 12 08 comments missing translations issue #4049

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Sm 2021 12 08 comments missing translations issue #4049

merged 2 commits into from
Dec 13, 2021

Conversation

sabinammm
Copy link
Contributor

Fixes #4026
Fixes #4043

Translations and gendered German was added only according to the issues cited above.

@sabinammm sabinammm requested review from philli-m and khamui and removed request for philli-m and khamui December 8, 2021 15:10
@sabinammm sabinammm changed the title Sm 2021 12 08 comments missing translations issue WIP Sm 2021 12 08 comments missing translations issue Dec 9, 2021
@sabinammm sabinammm changed the title WIP Sm 2021 12 08 comments missing translations issue Sm 2021 12 08 comments missing translations issue Dec 9, 2021
fuzzylogic2000
fuzzylogic2000 reviewed Dec 13, 2021
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a test fails. Will check that out!

@sabinammm
Copy link
Contributor Author

sabinammm commented Dec 13, 2021 •
edited
Loading

Looks good, but a test fails. Will check that out!
@fuzzylogic2000
This is a failure that only shows up in Github. It fails b/c of PR 4041, which was fixed in PR 4050. This was very strange b/c the test didn't fail within the oiginal PR, only after it was merged in this PR. Because of this failure on GitHub, the mistake in PR 4041 was discovered, though.
Also, if I run tests on this branch locally, there is no failed test:
image

I frankly do not understand why.

@fuzzylogic2000 fuzzylogic2000 force-pushed the sm-2021-12-08-comments-missing-translations-issue branch from d6bda91 to 431e5e7 Compare December 13, 2021 09:20
@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 4.77% 60/1258
🔴 Branches 3.59% 26/724
🔴 Functions 5.56% 23/414
🔴 Lines 8.65% 321/3711

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 431e5e7

@fuzzylogic2000 fuzzylogic2000 merged commit e9c121a into main Dec 13, 2021
@fuzzylogic2000 fuzzylogic2000 deleted the sm-2021-12-08-comments-missing-translations-issue branch December 13, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzylogic2000 fuzzylogic2000 fuzzylogic2000 approved these changes

@philli-m philli-m Awaiting requested review from philli-m

@khamui khamui Awaiting requested review from khamui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testing 5050: missing translation dev user front end: missing translation
2 participants
@sabinammm @fuzzylogic2000