Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/plans/templates: fix for PR #4041 syntax error #4050

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

sabinammm
Copy link
Contributor

Commit 2 in Pull Request #4041 broke the template for plan detail. This is because multiline tags in django template language are not possible (see https://code.djangoproject.com/ticket/8652).

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 4.7% 59/1254
🔴 Branches 3.46% 25/722
🔴 Functions 5.57% 23/413
🔴 Lines 8.56% 317/3702

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from ece0d23

@sabinammm sabinammm force-pushed the sm-2021-12-09-fix-template-refactor-error branch from 9896871 to b98cd96 Compare December 9, 2021 09:27
@sabinammm sabinammm requested a review from khamui December 9, 2021 09:27
@sabinammm sabinammm force-pushed the sm-2021-12-09-fix-template-refactor-error branch from b98cd96 to ece0d23 Compare December 9, 2021 09:48
@khamui
Copy link
Contributor

khamui commented Dec 9, 2021

visual verification of what was changed:

  • cms storefronts --> not sure how to test, code looks good
  • proposal list item
  • idea list item
  • map idea list item
  • plan detail
  • removable invite list item

@khamui khamui merged commit 513aed0 into main Dec 9, 2021
@khamui khamui deleted the sm-2021-12-09-fix-template-refactor-error branch December 9, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants