[Feature] Node selector & Tolerations support for helm chart

[Sharathmk99]

Is your feature request related to a problem? Please describe.
Currently helm chart doesn't support nodeSelector and tolerations for all liqo servrices.
This is needed when cluster has dedicated nodes for services which are tainted

Describe the solution you'd like
Add common field in values.yaml

common:
    nodeSelector:
        dedicated: services
    tolerations:
    - key: "dedicated"
      operator: "Equal"
      value: "services"
      effect: "NoSchedule"

Update all deployment and statefulset

{{- if ((.Values.common).nodeSelector) }}
nodeSelector:
{{- toYaml .Values.common.nodeSelector | nindent 8 }}
{{- end }}
{{- if ((.Values.common).tolerations) }}
tolerations:
{{- toYaml .Values.common.tolerations | nindent 8 }}
{{- end }}

Describe alternatives you've considered
Forked helm chart and made changes

Additional context
Once this is supported we can use liqoctl as below

liqoctl .... --set common.nodeSelector.dedicated=services --set common.tolerations[0].key=dedicated,common.tolerations[0].operator=Equal,common.tolerations[0].value=services,common.tolerations[0].effect=NoSchedule

[cheina97]

Hi @Sharathmk99, this is a good suggestion. I marked this issue as a good first issue, feel free to open a PR and propose your solution. It would be also really appreciated if you add the support for affinity to the helm chart.

[cheina97]

However, adding such changes to the helm chart will not change the virtual-kubelets created by Liqo. To add this feature to virtual-kubelets it is necessary to modify the liqo-controller-manager.

However, this change is not needed at the moment and may be applied in a future PR.

[Sharathmk99]

However, adding such changes to the helm chart will not change the virtual-kubelets created by Liqo. To add this feature to virtual-kubelets it is necessary to modify the liqo-controller-manager.

However, this change is not needed at the moment and may be applied in a future PR.

That's good point. Will open separate issue for that.