Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refund swaps #185

Merged
merged 7 commits into from
Jun 6, 2019
Merged

Refund swaps #185

merged 7 commits into from
Jun 6, 2019

Conversation

grandsmarquis
Copy link
Contributor

Description

This pull request introduce the possibility to monitor an existing swap and catch the refund action on all providers.

It also fixes some bugs inside of the Bitcoin Swap Js provider that were preventing party A to create a swap from the node.

@grandsmarquis grandsmarquis marked this pull request as ready for review June 5, 2019 08:34
Copy link
Collaborator

@monokh monokh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! just some minor comments

test/integration/swap/common.js Outdated Show resolved Hide resolved
@grandsmarquis grandsmarquis merged commit 9529843 into dev Jun 6, 2019
michaeltout pushed a commit to michaeltout/chainabstractionlayer that referenced this pull request Jan 29, 2022
* Enbales sending tx to null in ETH rpc provider

* Added refund transaction catching and Bitcoin node fixes

* documentation and removed debug logging

* unify claimAndVerify with refund test process

* Bump version 0.2.7

* Bump version 0.2.7
michaeltout pushed a commit to michaeltout/chainabstractionlayer that referenced this pull request Jan 29, 2022
* Enbales sending tx to null in ETH rpc provider

* Added refund transaction catching and Bitcoin node fixes

* documentation and removed debug logging

* unify claimAndVerify with refund test process

* Bump version 0.2.7

* Bump version 0.2.7
@kraikov kraikov deleted the refund-swap branch April 29, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants