-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refund swaps #185
Merged
Merged
Refund swaps #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monokh
reviewed
Jun 5, 2019
monokh
reviewed
Jun 5, 2019
monokh
approved these changes
Jun 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! just some minor comments
michaeltout
pushed a commit
to michaeltout/chainabstractionlayer
that referenced
this pull request
Jan 29, 2022
* Enbales sending tx to null in ETH rpc provider * Added refund transaction catching and Bitcoin node fixes * documentation and removed debug logging * unify claimAndVerify with refund test process * Bump version 0.2.7 * Bump version 0.2.7
michaeltout
pushed a commit
to michaeltout/chainabstractionlayer
that referenced
this pull request
Jan 29, 2022
* Enbales sending tx to null in ETH rpc provider * Added refund transaction catching and Bitcoin node fixes * documentation and removed debug logging * unify claimAndVerify with refund test process * Bump version 0.2.7 * Bump version 0.2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduce the possibility to monitor an existing swap and catch the refund action on all providers.
It also fixes some bugs inside of the Bitcoin Swap Js provider that were preventing party A to create a swap from the node.