Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer to have LIQUIBASE_HOME as a property so it can be passed on the commandline #3777

Closed
kdeenkhoorn opened this issue Feb 4, 2023 · 2 comments
Labels
good first issue This issue is an easy starter project for new contributors. TypeEnhancement

Comments

@kdeenkhoorn
Copy link

final String liquibaseHomeEnv = System.getenv("LIQUIBASE_HOME");

Is it possible to change the LIQUIBASE_HOME OS variable to a property so it can be passed on the java -jar liquibase-core.jar as a -D option ?
We have a hard time making this change to our deployment scripting to switch from java -jar notation to a bash script.
The majority of options can be passed on the commandline except these ones from the LiquibaseLauncher.

@FBurguer FBurguer changed the title Prefer to have LIQUIBASE_HOME as a property so it can be passed on the commandline or in propertiesfile Prefer to have LIQUIBASE_HOME as a property so it can be passed on the commandline Feb 8, 2023
@FBurguer FBurguer added TypeEnhancement good first issue This issue is an easy starter project for new contributors. labels Feb 8, 2023
@FBurguer
Copy link

FBurguer commented Feb 8, 2023

Hello! Thanks for creating this issue! i modify the title becaue supporting it as an argument in the properties file wouldnt make much sense but adding it as a property to pass on the command line sounds like a cool feature! I will add it to our queue of Feature Requests, but it can take a while for it to be address, you can always submitt a pr and we would love to help you working through it with you.

jccampanero added a commit to jccampanero/liquibase that referenced this issue Apr 8, 2023
jccampanero added a commit to jccampanero/liquibase that referenced this issue Apr 10, 2023
@filipelautert
Copy link
Collaborator

This was implemented on #4104 .

filipelautert pushed a commit that referenced this issue Oct 12, 2023
… to the CLI (#4104)

* #3777 Support system properties as a way of providing configuration options to the CLI.

* #3777 Define a more convenient naming convention for JVM properties.

* Improve JVM system property to environment mapping by using an enum class instead of a Map.

* Provide a friendly error message in case of liquibase home misconfiguration.

* Externalize command line settings allowing for being reused by both LiquibaseCommandLine and LiquibaseLauncher.


---------
Co-authored-by: filipe <flautert@liquibase.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue is an easy starter project for new contributors. TypeEnhancement
Projects
Development

No branches or pull requests

3 participants