Support system properties as a way of providing configuration options to the CLI

[jccampanero]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

The LiquibaseLauncher code, and the Liquibase CLI in general, have been enriched to support passing the different configuration options as JVM system properties.

Previously, such information could only be passed as operating system environment variables.

Fixes and augments, in order to provide a uniform way of reading the different configuration options, the scope of #3777.

Things to be aware of

Nothing.

Things to worry about

Nothing.

Additional Context

No test have been created for the issue.

[nvoxland]

Initial/Pre-Review Thoughts

The changes look good to me. Thanks!

Questions I have:

• None

Potential risks:

• None

What could make the full review difficult:

• Nothing

[jccampanero]

You are welcome @nvoxland Nathan.

[filipelautert]

Hello @jccampanero ,maybe instead of using a Map from string to string, could not we use an Enum class where they key is similar to the string name (LIQUIBASE_HOME_JVM_PROPERTY_NAME ) and it would have a "value" field that would be the parameter value ("liquibase.home") . What do you think? This way we don't need to populate maps, etc.

[jccampanero]

Hello @jccampanero ,maybe instead of using a Map from string to string, could not we use an Enum class where they key is similar to the string name (LIQUIBASE_HOME_JVM_PROPERTY_NAME ) and it would have a "value" field that would be the parameter value ("liquibase.home") . What do you think? This way we don't need to populate maps, etc.

Sorry for the late reply @filipelautert.

Yes, of course, I updated the code as requested. I used jvmPropertyName instead of value in the enum definition because I think it is more precise but please, feel free to adapt the code if you wish.

[filipelautert]

Yes, of course, I updated the code as requested. I used jvmPropertyName instead of value in the enum definition because I think it is more precise but please, feel free to adapt the code if you wish.

Nice, I believe it is better now as we can see that those values are used only for this purpose, thanks for applying the changes!

[jccampanero]

You are welcome @filipelautert, my pleasure.

[jccampanero]

Hello @jccampanero, I am testing some internal build process and using your branch as a guinea pig. Please let me know if you face any issues during this process. Thank you.

cc: @filipelautert

It is perfectly fine @sayaliM0412, please, feel free to use the branch for your tests, as you consider it appropriate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[adrian-velonis1]

Internal: https://datical.atlassian.net/browse/PD-3610