New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAP SQL Anywhere 17.0.11: Liquibase incorrectly reports that TIMESTAMP requested precision is longer than TIMESTAMP supported precision #3971
Comments
Thanks for the issue. There is similar "timestamp with time zone" logic for postgresql that will need to be adapted to sap sql now that it supports it. |
Does "that need to be adapted" mean that a committer will work on it, or does it mean that the project team expects the reported (me) to provide that fix? |
… reports that TIMESTAMP requested precision is longer than TIMESTAMP supported precision
I have startet work in this issue in my private fork: https://github.com/mkarg/liquibase/tree/mkarg/sap-sql-anywhere-liquibase-3971. Comments very welcome! 😃 |
… reports that TIMESTAMP requested precision is longer than TIMESTAMP supported precision
Hi @mkarg, thank you for reporting this issue and for creating a PR for it. Is there anything we can do to help you to move forward with this PR? |
Thank you for this kind offer, I really appreciate it. @filipelautert is already supporting me. Unfortunately I do not see how you can help right now, as the next step is that I need to check the JDBC driver's actual behavior. Once that is known, we can decide how to work around. |
… reports that TIMESTAMP requested precision is longer than TIMESTAMP supported precision
Yeah, I talked with Filipe after posting my comment. Cool, if there is anything I can help with please let me know. Thanks, |
… reports that TIMESTAMP requested precision is longer than TIMESTAMP supported precision
… that TIMESTAMP requested precision is longer than TIMESTAMP supported precision" (#4422) * Fixed #3971: SAP SQL Anywhere 17.0.11: Liquibase incorrectly reports that TIMESTAMP requested precision is longer than TIMESTAMP supported precision * Fixed Typo There was a closing angle missing when fixing the merge conflict.
Search first
Description
I am trying to
generateChangeLog
from a SAP SQL Anywhere 17.0.11 database which contains TIMESTAMP WITH TIME ZONE columns having a default of DEFAULT UTC TIMESTAMP.Liquibase incorrectly complains that the supported precision is shorter than the requested precision:
The message was true for older versions of SQL Anywhere which did not support "WITH TIME ZONE", but since current versions support "WITH TIME ZONE" this message is wrong now.
Steps To Reproduce
generateChangeLog
using SQL Anywhere 17.0.11 having a column with the definitionTIMESTAMP WITH TIMEZONE DEFAULT UTC TIMESTAMP
.Expected/Desired Behavior
Successfully accepts both, the type
TIMESTAMP WITH TIMEZONE
and the default valueUTC TIMESTAMP
.Liquibase Version
latest
Database Vendor & Version
SAP SQL Anywhere 17.0.11
Liquibase Integration
Maven Plugin
Liquibase Extensions
none
OS and/or Infrastructure Type/Provider
Windows 10
Additional Context
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: