Fixed liquibase#3971: SAP SQL Anywhere 17.0.11: Liquibase incorrectly…

… reports that TIMESTAMP requested precision is longer than TIMESTAMP supported precision
mkarg · Jun 26, 2023 · 83816e7 · 83816e7
1 parent e8eb891
commit 83816e7
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/liquibase-standard/src/main/java/liquibase/datatype/core/TimestampType.java b/liquibase-standard/src/main/java/liquibase/datatype/core/TimestampType.java
@@ -130,9 +130,12 @@ public DatabaseDataType toDatabaseDataType(Database database) {
             && (database instanceof PostgresDatabase
             || database instanceof OracleDatabase
             || database instanceof H2Database
-            || database instanceof HsqlDatabase)) {
+            || database instanceof HsqlDatabase
+            || database instanceof SybaseASADatabase)) {
 
-            if (database instanceof PostgresDatabase || database instanceof H2Database) {
+            if (database instanceof PostgresDatabase
+            || database instanceof H2Database
+            || database instanceof SybaseASADatabase) {
                 type.addAdditionalInformation("WITH TIME ZONE");
             } else {
                 type.addAdditionalInformation("WITH TIMEZONE");
@@ -145,12 +148,14 @@ public DatabaseDataType toDatabaseDataType(Database database) {
                 && (database instanceof PostgresDatabase
                 || database instanceof OracleDatabase)
                 || database instanceof H2Database
-                || database instanceof HsqlDatabase){
+                || database instanceof HsqlDatabase
+                || database instanceof SybaseASADatabase){
             String additionalInformation = this.getAdditionalInformation();
 
             if (additionalInformation != null) {
                 String additionInformation = additionalInformation.toUpperCase(Locale.US);
-                if ((database instanceof PostgresDatabase || database instanceof H2Database) && additionInformation.toUpperCase(Locale.US).contains("TIMEZONE")) {
+                if ((database instanceof PostgresDatabase || database instanceof H2Database || database instanceof SybaseASADatabase)
+                        && additionInformation.toUpperCase(Locale.US).contains("TIMEZONE")) {
                     additionalInformation = additionInformation.toUpperCase(Locale.US).replace("TIMEZONE", "TIME ZONE");
                 }
                 // CORE-3229 Oracle 11g doesn't support WITHOUT clause in TIMESTAMP data type
@@ -163,6 +168,11 @@ public DatabaseDataType toDatabaseDataType(Database database) {
                     // http://www.h2database.com/html/datatypes.html
                     additionalInformation = null;
                 }
+
+                if ((database instanceof SybaseASADatabase) && additionInformation.startsWith("WITHOUT")) {
+                    // https://help.sap.com/docs/SAP_SQL_Anywhere/93079d4ba8e44920ae63ffb4def91f5b/81fe3e6b6ce2101487d8acce02f6aba5.html
+                    additionalInformation = null;
+                }
             }
 
             type.addAdditionalInformation(additionalInformation);