#1366 DateTimeType.java:38 NullPointerException

[mironbalcerzak]

---

name: Pull Request
about: NPE in DateTimeType core class
title: 'Fix For NPE'
labels: Status:Discovery
assignees: ''

---

Environment

Liquibase Version: 4.0.0

Pull Request Type

• Bug fix (non-breaking change which fixes an issue.)
• Enhancement/New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

NPE in DateTimeType in liquibase 4.0.0
More on that here: #1366

Steps To Reproduce

Generate Changelog for Oracle DB

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Documentation Updated

Need Help?

Come chat with us on our discord channel

[codecov]

Codecov Report

Merging #1367 into master will not change coverage.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master    #1367   +/-   ##
=========================================
  Coverage     48.20%   48.20%           
- Complexity     7558     7559    +1     
=========================================
  Files           755      755           
  Lines         36456    36456           
  Branches       6645     6646    +1     
=========================================
  Hits          17574    17574           
  Misses        16522    16522           
  Partials       2360     2360           

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/liquibase/datatype/core/DateTimeType.java	28.70% <33.33%> (ø)	18.00 <16.00> (ø)
...e/src/main/java/liquibase/util/DependencyUtil.java	92.10% <0.00%> (-0.88%)	0.00% <0.00%> (ø%)
...re/src/main/java/liquibase/util/ISODateFormat.java	79.16% <0.00%> (+2.08%)	16.00% <0.00%> (+1.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e76ca...2498b07. Read the comment docs.

[molivasdat]

Thanks @mironbalcerzak for creating this PR.
Here’s what happens next:

A member of the Liquibase team will take a look at your contribution and may suggest
changes, additional tests, or provide other feedback. The PR will be prioritized
according to our development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

[mironbalcerzak]

@kevin-at-datical, @molivasdat
Hey there. Just checking if this PR was not lost "in the process" :) can you please review/accept it?

[mironbalcerzak]

@kevin-at-datical, @molivasdat bump

[molivasdat]

Hi @mironbalcerzak It was not lost in process, just taking a bit of time to incorporate changes into the code. We should be able to pull this into the next release.

[mironbalcerzak]

@nvoxland, @molivasdat, @kevin-at-datical - guys...it's nearly half a year that this PR is open with major bug with Oracle ... can you kindly merge it please?

[molivasdat]

Hi @mironbalcerzak , Yes this is a simple change. Thanks for the pointer. We are working on getting fixes in. Apologies. It won't make 4.3.2 but the next one. We got a new team in place to help out.

[sync-by-unito]

➤ Erzsebet Carmean commented:

Liquibase unit, integration and functional test suites passed. Moving this to ready to merge. Thanks for the PR!

[nvoxland]

Merged into master for 4.4.0