Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DateTime NPE LB 623 #1745

Closed
wants to merge 4 commits into from
Closed

Fix for DateTime NPE LB 623 #1745

wants to merge 4 commits into from

Conversation

wwillard7800
Copy link
Contributor

@wwillard7800 wwillard7800 commented Mar 3, 2021

Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #1745 (07b17ab) into 4.3.x (18202bc) will decrease coverage by 1.51%.
The diff coverage is 33.20%.

Impacted file tree graph

@@             Coverage Diff              @@
##              4.3.x    #1745      +/-   ##
============================================
- Coverage     49.59%   48.07%   -1.52%     
+ Complexity     7862       53    -7809     
============================================
  Files           757      799      +42     
  Lines         37024    38819    +1795     
  Branches       6699     6950     +251     
============================================
+ Hits          18363    18664     +301     
- Misses        16231    17681    +1450     
- Partials       2430     2474      +44     
Impacted Files Coverage Δ Complexity Δ
...n/java/liquibase/integration/cdi/CDILiquibase.java 55.35% <ø> (ø) 9.00 <0.00> (?)
.../main/java/liquibase/change/AbstractSQLChange.java 82.03% <0.00%> (ø) 0.00 <0.00> (-29.00)
...in/java/liquibase/change/core/AddColumnChange.java 57.03% <0.00%> (-0.45%) 0.00 <0.00> (-32.00)
.../java/liquibase/change/core/CreateTableChange.java 72.22% <0.00%> (ø) 0.00 <0.00> (-48.00)
...quibase/change/core/ExecuteShellCommandChange.java 15.38% <ø> (ø) 0.00 <0.00> (-13.00)
...ase/changelog/StandardChangeLogHistoryService.java 46.40% <0.00%> (-0.34%) 0.00 <0.00> (-31.00)
...e/changelog/visitor/LoggingChangeExecListener.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...liquibase/changelog/visitor/ValidatingVisitor.java 68.53% <0.00%> (-1.36%) 0.00 <0.00> (-31.00)
...in/java/liquibase/command/core/SyncHubCommand.java 85.52% <ø> (-2.64%) 0.00 <0.00> (-25.00)
.../java/liquibase/database/core/Ingres9Database.java 26.31% <0.00%> (ø) 0.00 <0.00> (-8.00)
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b73abb...07b17ab. Read the comment docs.

@wwillard7800 wwillard7800 changed the title Lb 623 Fix for DateTime NPE LB 623 Mar 3, 2021
@XDelphiGrl XDelphiGrl changed the base branch from 4.3.x to master March 29, 2021 13:30
@molivasdat
Copy link
Contributor

I believe this was fixed as part of #1377.

@sync-by-unito
Copy link

sync-by-unito bot commented May 20, 2021

➤ Wesley Willard commented:

Yes, this fix was merged to master on April 5th

@nvoxland
Copy link
Contributor

This was a PR for a test branch and should not have been created. The actual PR #1367 was brought in separately.

@nvoxland nvoxland closed this Jul 30, 2021
@nvoxland nvoxland deleted the LB-623 branch July 30, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants