Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve default value of invalid autoincrement column types in Postgres (DAT-8670) #2643

Merged
merged 9 commits into from
Mar 24, 2022

Conversation

StevenMassaro
Copy link
Contributor

@StevenMassaro StevenMassaro commented Mar 15, 2022

Postgres reports that varchar columns are autoincrement and have a default value when created like this:

CREATE SEQUENCE mysequence INCREMENT 5 START 100;
CREATE TABLE products ( product_no varchar(20) DEFAULT nextval('mysequence'));

and this change allows Liquibase to snapshot these columns properly. The default value is preserved, and the autoincrement information is removed.

@github-actions
Copy link

github-actions bot commented Mar 15, 2022

Unit Test Results

  4 125 files  +11    4 125 suites  +11   38m 1s ⏱️ + 1m 57s
  4 340 tests +  1    4 126 ✔️ ±  0     214 💤 +  1  0 ±0 
47 080 runs  +11  42 448 ✔️ ±  0  4 632 💤 +11  0 ±0 

Results for commit 6cef945. ± Comparison against base commit a8440e1.

♻️ This comment has been updated with latest results.

@kataggart kataggart added this to To Do in Conditioning++ via automation Mar 16, 2022
Conditioning++ automation moved this from To Do to Done Mar 23, 2022
@StevenMassaro StevenMassaro reopened this Mar 23, 2022
Conditioning++ automation moved this from Done to To Do Mar 23, 2022
@StevenMassaro StevenMassaro changed the title support autoincrement varchar columns (DAT-8670) preserve default value of invalid autoincrement column types in Postgres (DAT-8670) Mar 24, 2022
@StevenMassaro StevenMassaro merged commit 0f95718 into master Mar 24, 2022
Conditioning++ automation moved this from To Do to Done Mar 24, 2022
@StevenMassaro StevenMassaro deleted the DAT-8670 branch March 24, 2022 12:38
@nvoxland nvoxland added this to the NEXT milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants