-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preserve default value of invalid autoincrement column types in Postgres (DAT-8670) #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryaaki2
approved these changes
Mar 18, 2022
nvoxland
suggested changes
Mar 18, 2022
liquibase-core/src/main/java/liquibase/datatype/core/VarcharType.java
Outdated
Show resolved
Hide resolved
…ype that we expect (valid for auto-increment)
nvoxland
approved these changes
Mar 21, 2022
StevenMassaro
changed the title
support autoincrement varchar columns (DAT-8670)
preserve default value of invalid autoincrement column types in Postgres (DAT-8670)
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres reports that varchar columns are autoincrement and have a default value when created like this:
and this change allows Liquibase to snapshot these columns properly. The default value is preserved, and the autoincrement information is removed.