Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor refactorings to CommandTests and TableOutput (DAT-9989) #2849

Merged
merged 2 commits into from
May 18, 2022

Conversation

StevenMassaro
Copy link
Contributor

Environment

Liquibase Version: N/A

Liquibase Integration & Version: N/A

Liquibase Extension(s) & Version: N/A

Database Vendor & Version: N/A

Operating System Type & Version: N/A

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Change array to list in TableOutput method
  • Add option to ignore whitespace in CommandTests "contains" comparison

Steps To Reproduce

Actual Behavior

Expected/Desired Behavior

Screenshots (if appropriate)

Additional Context

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us in the Liquibase Forum.

@github-actions
Copy link

github-actions bot commented May 16, 2022

Unit Test Results

  4 512 files  ±0    4 512 suites  ±0   38m 24s ⏱️ - 3m 40s
  4 386 tests ±0    4 172 ✔️ ±0     214 💤 ±0  0 ±0 
51 912 runs  ±0  46 904 ✔️ ±0  5 008 💤 ±0  0 ±0 

Results for commit fd6111d. ± Comparison against base commit e63de2b.

♻️ This comment has been updated with latest results.

@StevenMassaro StevenMassaro merged commit 3af6467 into DAT-9298 May 18, 2022
@StevenMassaro StevenMassaro deleted the DAT-9989 branch May 18, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants