prefer license specified in LIQUIBASE_LICENSE_KEY edge case (DAT-10409) #2858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment
Liquibase Version: N/A
Liquibase Integration & Version: CLI
Liquibase Extension(s) & Version: N/A
Database Vendor & Version: N/A
Operating System Type & Version: N/A
Pull Request Type
Description
A user could specify their license key using the
LIQUIBASE_PRO_LICENSE_KEY
property in any provider (perhaps environment variable) and specify a second license key using theLIQUIBASE_LICENSE_KEY
property in the defaults file. The defaults file value provider is not registered until after invoking the license service's license installation code, and the license service caches installed licenses so that it does not have to recheck for license keys. However, this means that in the above example, a license specified in the defaults file is not loaded because the license in the environment variable is erroneously installed and cached first.Steps To Reproduce
LIQUIBASE_PRO_LICENSE_KEY
liquibase.licenseKey
Actual Behavior
The license from the environment variable is loaded.
Expected/Desired Behavior
The license from the defaults file is loaded.
Screenshots (if appropriate)
Additional Context
Fast Track PR Acceptance Checklist:
Need Help?
Come chat with us in the Liquibase Forum.