prefer license specified in LIQUIBASE_LICENSE_KEY edge case (DAT-10409)

[StevenMassaro]

Environment

Liquibase Version: N/A

Liquibase Integration & Version: CLI

Liquibase Extension(s) & Version: N/A

Database Vendor & Version: N/A

Operating System Type & Version: N/A

Pull Request Type

• Bug fix (non-breaking change which fixes an issue.)
• Enhancement/New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

A user could specify their license key using the LIQUIBASE_PRO_LICENSE_KEY property in any provider (perhaps environment variable) and specify a second license key using the LIQUIBASE_LICENSE_KEY property in the defaults file. The defaults file value provider is not registered until after invoking the license service's license installation code, and the license service caches installed licenses so that it does not have to recheck for license keys. However, this means that in the above example, a license specified in the defaults file is not loaded because the license in the environment variable is erroneously installed and cached first.

Steps To Reproduce

• Specify a pro license key in an environment variable LIQUIBASE_PRO_LICENSE_KEY
• Specify a pro license key in the defaults file using liquibase.licenseKey
• Run any command

Actual Behavior

The license from the environment variable is loaded.

Expected/Desired Behavior

The license from the defaults file is loaded.

Screenshots (if appropriate)

Additional Context

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Added Test Harness Test(s)
• Documentation Updated

Need Help?

Come chat with us in the Liquibase Forum.

[github-actions]

Unit Test Results

  4 512 files  ±0    4 512 suites  ±0   37m 11s ⏱️ ±0s
  4 414 tests ±0    4 200 ✔️ ±0     214 💤 ±0  0 ❌ ±0 
52 248 runs  ±0  47 240 ✔️ ±0  5 008 💤 ±0  0 ❌ ±0 

Results for commit 3690618. ± Comparison against base commit fb86d98.

♻️ This comment has been updated with latest results.