-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output "may lose settings" warning on mysql/mariadb for more impacted change types #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvoxland
changed the title
Output warning o
Output "may loose settings" warning on mysql/mariadb for setColumnRemarks
Jul 6, 2022
…to more SqlGenerators
nvoxland
changed the title
Output "may loose settings" warning on mysql/mariadb for setColumnRemarks
Output "may loose settings" warning on mysql/mariadb for more impacted change types
Jul 6, 2022
suryaaki2
approved these changes
Jul 20, 2022
For this PR tested if every change type listed before had a warning msg on MySQL and MariaDB:
|
kataggart
changed the title
Output "may loose settings" warning on mysql/mariadb for more impacted change types
Output "may lose settings" warning on mysql/mariadb for more impacted change types
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
MySQL/MariaDB's
alter table ... modify column
syntax requires a complete redefinition of the column when modifying a column, such as setting a comment, changing a datatype, etc.The the setColumnRemarks, addDefaultValue, etc change does not support all possible column features, only the data type so anything else (like nullability etc) will be lost.
This PR expands the existing warning we had for modifyDataType, since that is all we can do for this.
Things to be aware of
Things to worry about