-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved handling of endDelimiter="/" #3118
Conversation
…inning of a line. Not in the middle and likely a division sign
…inning of a line. Not in the middle and likely a division sign
…inning of a line. Not in the middle and likely a division sign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix improves handling of the Oracle end delimiter
/
by checking to see if the/
is at the beginning of a line and not within a statement. - New unit tests added.
- No additional testing required.
APPROVED
Thank you for the fix. I tested Liquibase 4.15 with my Oracle database setup and the problem has been resolved. |
This issue is seen again in 4.24 and 4.25. Is there something that broke this ? |
Follow-up (4.29.0): #5704: "Fix SQL execution issue with endDelimiter '/' and splitStatements" |
Impact
Description
If people put endDelimiter="/", they really mean the oracle-style syntax of:
and we should treat that as such and not actually use "/" as a simple delimiter. Otherwise, something like:
splits in the wrong spot.
Fixes #2688
Things to be aware of
/
like this, this change just extends that to explicitly specifying endDelimiter="/"Things to worry about