Fix javadoc references, links and spaces. #3768
Conversation
|
Initial/Pre-Review Thoughts Thanks for the fix. A quick scan looks right, but need someone to double check there isn't any unexpected changes to the javadocs Questions I have:
Potential risks:
What could make the full review difficult:
|
There was a problem hiding this comment.
Approved
Review and testing results:
PR changes looks good to me. Minor corrections (extra parenthesis removed from javadoc). Build and tests executed successfully (Functional tests failing at the moment, but that is not related with changes made here).
Things to be aware of:
- None
Things to worry about:
- None
…quibase into arturobernalg-feature/javadoc
|
Functional tests running here: https://github.com/liquibase/liquibase-pro-tests/actions/runs/4928321834 |
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| /** | |||
| * This interface defines how objects can be extended with additional attributes at runtime without subclassing and exposes the ability to query attributes without resorting to reflection. | |||
| * | |||
| * <p> | |||
There was a problem hiding this comment.
For those who were unaware, as I was prior to this review, the parser infers the closing </p>. :)
There was a problem hiding this comment.
Do you like cleaner JavaDoc output, with correctly formatted URLs and clean spacing between paragraphs? You're in luck! This PR provides just that, with the addition of fixing two places in the documentation where the incorrect variable name was referenced in the JavaDoc annotations.
- Functional and test harness executions passing.
- No additional testing required.
APPROVED
# Conflicts: # liquibase-standard/src/main/java/liquibase/hub/HubServiceFactory.java
Impact
Description