-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAT-13285 - Fix CheckSum generation issues + improvement #3914
Conversation
…rateCheckSum logic from createProcedure change
…same method logic for CreateView change, plus some minor refactorings.
… into fix-issue-3549
… into fix-issue-3549
…hich changed after upgrading algorithm version.
@filipelautert - @suryaaki2 - @XDelphiGrl: guys, I think I'm done with the latest changes we have decided to incorporate as part of this PR (SQLFile and Change objects which can specify body as part of a SQL file). Please feel free to review this again and let me know if you have any questions/requested changes. Thanks, |
liquibase-standard/src/main/java/liquibase/change/core/SQLFileChange.java
Show resolved
Hide resolved
liquibase-standard/src/main/java/liquibase/change/AbstractChange.java
Outdated
Show resolved
Hide resolved
…n computing checksum. - Extract expanding stream content in to a separate component.
- PropertyExpandingStream refactoring.
@nvoxland would you mind having a look at this when you have a chance? But it's basically what we've seen/discussed earlier. cc: @filipelautert - @suryaaki2 |
Adding a TEST note about the latest changes made here was an issue users reported here. The fix for this has ended up with changes on Basically, the issue was property value was not being replaced in an indicated SQLFile. Here’s a changelog example of the discussed issue:
Where
|
…reateProcedure and CreateView. - Minor refactoring done on tests.
# Conflicts: # liquibase-standard/src/main/java/liquibase/change/core/CreateProcedureChange.java
…y changesets during checksum upgrade (#4193) * Makes sure that we reset ChangeLogHistoryServiceFactory after upgradingCheckSums. * Rollback DropAllCommand.java changes. * Trigger Build * Rollback changes * Makes ReleaseLocks Command checksum upgrade consistent with ListLocks * Fix null md5sum issues during checksum upgrades * When updating checksums use the stored file path instead of the generated one as we changed the way that we store paths during the years * Fix validate command * Fix unexpected-changesets command * Adding unit tests for PR 4210 . --------- Co-authored-by: Sayali M <sayali@Sayalis-MacBook-Pro>
Impact
Description
Fixes #4192
Fixes #3549