DAT-14642 - Prevents Liquibase from incorrectly attempting to redeploy changesets during checksum upgrade #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipelautert
changed the title
suryaaki2
approved these changes
Apr 28, 2023
nvoxland
suggested changes
May 1, 2023
filipelautert
changed the title
|
@XDelphiGrl Can you review the PR? |
XDelphiGrl
changed the title
|
Passing functional tests for Postgres are here: https://github.com/liquibase/liquibase-pro-tests/actions/runs/4872052466. The issue was that there is a test validation fix for the |
* When updating checksums use the stored file path instead of the generated one as we changed the way that we store paths during the years
suryaaki2
added a commit
that referenced
this pull request
May 5, 2023
* Compute checksum method updated * Checksum logic updated for visitors and changes. * GenerateCheckSum field filter logic updated, plus refactoring on generateCheckSum logic from createProcedure change * generateCheckSum code refactoring done for Create Procedure, updated same method logic for CreateView change, plus some minor refactorings. * Fixed unit tests. * Added createProcedure and changeSet unit tests * Added back procedure text null check. * Null check added on normalizing stream constructor method. * Correction to previous commmit on null check added on normalizing stream constructor * CURRENT_CHECKSUM_ALGORITHM_VERSION updated from 8 to 9. * Update checksum test assertions to match with algorithm version change * Review comments applied. * Update encoding configuration for CreateProcedure change. * CreateProcedureChange test name updated. * Update calculateCheckSum command tests to upgrade expected checksum which changed after upgrading algorithm version. * CreateProcedure and CreateView tests added, plus minor refactorings. * Merge * Updates checksum for tests. * Exclude fields for PRO change types to avoid recalculating checksum when there are not significant changes. * Added a generic generateCheckSum method to use it across some different change types extending from CreateProcedureChange. * Add missing parameter * - Update change objects (CreateProcedure, CreateView and SQLFile) to make use properties updates when using a SQL file - Added unit tests for changes made. * - Support added to exclude change set attribute fields not needed when computing checksum. - Extract expanding stream content in to a separate component. * - Undo fields exclusion from generateCheckSum (AbstractSQLChange). - PropertyExpandingStream refactoring. * - New checksum unit tests added for some more change attributes for CreateProcedure and CreateView. - Minor refactoring done on tests. * Undo db change property changes recently done from CreateProcedure change. * DAT-14642 - Prevents Liquibase from incorrectly attempting to redeploy changesets during checksum upgrade (#4193) * Makes sure that we reset ChangeLogHistoryServiceFactory after upgradingCheckSums. * Rollback DropAllCommand.java changes. * Trigger Build * Rollback changes * Makes ReleaseLocks Command checksum upgrade consistent with ListLocks * Fix null md5sum issues during checksum upgrades * When updating checksums use the stored file path instead of the generated one as we changed the way that we store paths during the years * Fix validate command * Fix unexpected-changesets command * Adding unit tests for PR 4210 . --------- Co-authored-by: Sayali M <sayali@Sayalis-MacBook-Pro> --------- Co-authored-by: Daniel Mallorga <dmallorga@liquibase.com> Co-authored-by: Daniel Mallorga <75833793+MalloD12@users.noreply.github.com> Co-authored-by: filipe <filipe@caelum> Co-authored-by: Sayali M <sayali@Sayalis-MacBook-Pro> Co-authored-by: suryaaki2 <80348493+suryaaki2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Fix handling of ChangeLogHistoryServiceFactory when dealing with checksum upgrades.