Switch to distribute jars generated by Java 11 allowing Jakarta cdi 4 upgrade #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [jakarta.enterprise.cdi-api](https://github.com/cdi-spec/cdi) from 3.0.0 to 4.0.1. - [Release notes](https://github.com/cdi-spec/cdi/releases) - [Commits](jakartaee/cdi@3.0.0...4.0.1) --- updated-dependencies: - dependency-name: jakarta.enterprise:jakarta.enterprise.cdi-api dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This was referenced Apr 12, 2023
…ibase/liquibase into github-action-jakarta-cdi-4-upgrade
filipelautert
changed the title
filipelautert
changed the title
filipelautert
commented
Apr 13, 2023
.github/workflows/build.yml
Outdated
| @@ -273,10 +279,10 @@ jobs: | |||
| script: | | |||
| core.setOutput("testResultsArtifact", "liquibase-test-results-integration-${{ matrix.testSystem }}".replace(/[^a-zA-Z0-9\-_]/g, "_")); | |||
|
|
|||
| - name: Set up JDK 8 | |||
There was a problem hiding this comment.
Keep 8 so we can test with 8
filipelautert
requested review from
nvoxland,
abrackx,
StevenMassaro,
XDelphiGrl and
suryaaki2
StevenMassaro
approved these changes
Apr 18, 2023
.github/workflows/build.yml
Outdated
| - name: Build & Test Java 8 | ||
| if: ${{ matrix.java == 8}} | ||
| run: | | ||
| mvn -B "-Dbuild.repository.owner=${{ needs.setup.outputs.thisRepositoryOwner }}" "-Dbuild.repository.name=${{ needs.setup.outputs.thisRepositoryName }}" "-Dbuild.branch=${{ needs.setup.outputs.thisBranchName }}" "-Dbuild.number=${{ github.run_number }}" "-Dbuild.commit=${{ needs.setup.outputs.thisSha }}" "-DtrimStackTrace=false" -pl '!liquibase-dist,!liquibase-cdi-jakarta' clean test package surefire-report:report | ||
| - name: Build & Test |
There was a problem hiding this comment.
Can you change this step to be called something like "Build & Test all other Java versions"
There was a problem hiding this comment.
I'm calling it non-jdk-8 to be compliant with the pom profile
suryaaki2
approved these changes
May 16, 2023
XDelphiGrl
reviewed
May 16, 2023
liquibase-cdi-jakarta/src/main/java/liquibase/integration/jakarta/cdi/CDIBootstrap.java
Show resolved
Hide resolved
XDelphiGrl
approved these changes
May 16, 2023
There was a problem hiding this comment.
PR updates Weld and the Jakarata Enterprise CDI API dependencies for liquibase-cdi-jakarta. Weld is now 5.1.0.Final and the CDI API is 4.0.1. The associated GitHub workflows are updated to build the Liquibase Jakarta CDI plugin with Java 11 as required by CDI 5.
- No testing required.
APPROVED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
cdi version 5 requires Java 11, but liquibase still supports Java 8. . In order to use it some changes were made:
With that we are able to accomplish the dependabot requirements:
Relevant comments from dependabot issue: #3891 (comment)