Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump weld-se-core from 4.0.3.Final to 5.1.0.Final #3891

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 3, 2023

Bumps weld-se-core from 4.0.3.Final to 5.1.0.Final.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from filipelautert as a code owner March 3, 2023 02:59
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Unit Test Results

  1 465 files   -   3 852    1 465 suites   - 3 852   4m 10s ⏱️ - 31m 12s
  3 958 tests  -      950    3 945 ✔️  -      744    9 💤  -    210  0 ±0    4 🔥 +  4 
15 502 runs   - 47 248  15 447 ✔️  - 41 266  43 💤  - 5 994  0 ±0  12 🔥 +12 

For more details on these errors, see this check.

Results for commit f77c63e. ± Comparison against base commit fd07dbf.

@nvoxland
Copy link
Contributor

nvoxland commented Mar 8, 2023

Initial/Pre-Review Thoughts

It looks like the new weld version does not support java 8 and is also missing classes that some of the tests are looking for on newer versions.

We may need to merge this and #3890 into a single branch since they possibly go together?

Questions I have:

  • What is the impact to CDI users that upgrade their runtime to 5.x if we don't fix this? Is liquibase unusable? Or does it work fine? (like new spring does)
  • What will it take to support both CDI 4.x and 5.x?, since users will be using both
  • What will it take to get the tests running on java 11+?
  • How do we deal with the fact that java 8 doesn't support the new CDI versions?

Potential risks:

  • None

What could make the full review difficult:

  • Lots of unknowns

@filipelautert
Copy link
Collaborator

@dependabot rebase

Bumps weld-se-core from 4.0.3.Final to 5.1.0.Final.

---
updated-dependencies:
- dependency-name: org.jboss.weld.se:weld-se-core
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/org.jboss.weld.se-weld-se-core-5.1.0.Final branch from f77c63e to 941c508 Compare March 31, 2023 18:35
@filipelautert filipelautert self-assigned this Apr 12, 2023
@filipelautert
Copy link
Collaborator

Replaced by #4119

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 12, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/org.jboss.weld.se-weld-se-core-5.1.0.Final branch April 12, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code sprint2023-48
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants