Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ordering of clause for Oracle global temporary tables SQL generation #5887

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix ordering of clause for Oracle global temporary tables SQL generation #5887

merged 1 commit into from
May 8, 2024

Conversation

wwillard7800
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The ordering of the Oracle SQL for global temporary tables should have GLOBAL TEMPORARY, not TEMPORARY GLOBAL'. Also, we should support the ON COMMIT` clause.

Things to be aware of

Things to worry about

Additional Context

@filipelautert filipelautert self-requested a review May 7, 2024 15:21
@filipelautert filipelautert added this to the 1NEXT milestone May 8, 2024
@filipelautert filipelautert merged commit 65f2994 into master May 8, 2024
36 of 38 checks passed
@filipelautert filipelautert deleted the fix-global-temporary-table-generator branch May 8, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipelautert filipelautert filipelautert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Liquibase Open Source
Status: Done
Milestone
v4.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wwillard7800 @filipelautert