Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_cli: don't change the type of sys.argv when monkeypatching it #709

Merged
merged 1 commit into from
May 22, 2024
Merged

test_cli: don't change the type of sys.argv when monkeypatching it #709

merged 1 commit into from
May 22, 2024

Commits on May 21, 2024

  1. test_cli: don't change the type of sys.argv when monkeypatching it 

    When setting up for the CLI tests, we inadvertently change the type of
sys.argv from list to tuple. That worked with OG docopt, but breaks
docopt-ng. More importantly, the Python docs say sys.argv is a _list_.

So even though docopt was able to handle it being a tuple, and docopt-ng
seems (from a cursory look at its source) to still handle it being a
string, let's use the correct type.

Fixes: #708
    @jonasmalacofilho
    jonasmalacofilho committed May 21, 2024
    Configuration menu
    Copy the full SHA
    470b159 View commit details
    Browse the repository at this point in the history