Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove update gRPC enpoint and usecase implementation #222

Merged
merged 1 commit into from
Nov 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ The primary use case for flintlock is to create microVMs on a bare-metal host wh

Using API requests (via gRPC or HTTP):

- Create, update, delete microVMs using Firecracker
- Create and delete microVMs using Firecracker
- Manage the lifecycle of microVMs (i.e. start, stop, pause)
- Configure microVM metadata via cloud-init, ignition etc
- Use OCI images for microVM volumes, kernel and initrd
Expand Down
423 changes: 132 additions & 291 deletions api/services/microvm/v1alpha1/microvms.pb.go

Large diffs are not rendered by default.

137 changes: 0 additions & 137 deletions api/services/microvm/v1alpha1/microvms.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions api/services/microvm/v1alpha1/microvms.proto
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ service MicroVM {
post: "/v1alpha1/microvm"
};
}
rpc UpdateMicroVM(UpdateMicroVMRequest) returns (UpdateMicroVMResponse) {
option (google.api.http) = {
put: "/v1alpha1/microvm/{microvm.namespace}/{microvm.id}"
};
}
rpc DeleteMicroVM(DeleteMicroVMRequest) returns (google.protobuf.Empty) {
option (google.api.http) = {
delete: "/v1alpha1/microvm/{namespace}/{id}"
Expand Down Expand Up @@ -65,15 +60,6 @@ message DeleteMicroVMRequest {
string namespace = 2;
}

message UpdateMicroVMRequest {
flintlock.types.MicroVMSpec microvm = 1;
google.protobuf.FieldMask update_mask = 2;
}

message UpdateMicroVMResponse {
flintlock.types.MicroVMSpec microvm = 1;
}

message GetMicroVMRequest {
string id = 1;
string namespace = 2;
Expand Down
46 changes: 0 additions & 46 deletions api/services/microvm/v1alpha1/microvms.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,44 +39,6 @@
]
}
},
"/v1alpha1/microvm/{microvm.namespace}/{microvm.id}": {
"put": {
"operationId": "MicroVM_UpdateMicroVM",
"responses": {
"200": {
"description": "A successful response.",
"schema": {
"$ref": "#/definitions/v1alpha1UpdateMicroVMResponse"
}
},
"default": {
"description": "An unexpected error response.",
"schema": {
"$ref": "#/definitions/rpcStatus"
}
}
},
"parameters": [
{
"name": "microvm.namespace",
"description": "Namespace is the name of the namespace the microvm belongs to.",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "microvm.id",
"description": "ID is the identifier of the microvm.\nIf this empty at creation time a ID will be automatically generated.",
"in": "path",
"required": true,
"type": "string"
}
],
"tags": [
"MicroVM"
]
}
},
"/v1alpha1/microvm/{namespace}": {
"get": {
"operationId": "MicroVM_ListMicroVMs",
Expand Down Expand Up @@ -549,14 +511,6 @@
}
}
}
},
"v1alpha1UpdateMicroVMResponse": {
"type": "object",
"properties": {
"microvm": {
"$ref": "#/definitions/typesMicroVMSpec"
}
}
}
}
}
36 changes: 0 additions & 36 deletions api/services/microvm/v1alpha1/microvms_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading