Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Add action to bump version of firecracker in e2es #304

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

Callisto13
Copy link
Member

@Callisto13 Callisto13 commented Dec 3, 2021

Note: The firecracker version included in the bootstrap.sh of this PR
is a dummy version so I can see that everything works.
(Everything code-wise still works, the number is just one behind what
it should be while I set up.)

The action will open a PR to bump the version when a new one is
available upstream.
The new fork firecracker release wont actually exist yet, as there are some
manual steps required to update the macvtap feature branch on our fork.
These manual steps will be detailed in the PR.

See it in action here: #307

@Callisto13 Callisto13 added kind/feature New feature or request area/testing Indicates an issue related to test area/firecracker Indicates an issue or PR related to Firecracker labels Dec 3, 2021
@github-actions github-actions bot added the size/s label Dec 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #304 (bf2109c) into main (5fa3d5a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   58.64%   58.64%           
=======================================
  Files          50       50           
  Lines        2457     2457           
=======================================
  Hits         1441     1441           
  Misses        900      900           
  Partials      116      116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa3d5a...bf2109c. Read the comment docs.

@Callisto13 Callisto13 force-pushed the bump-fork branch 6 times, most recently from 9aa60d8 to 21a03ef Compare December 6, 2021 13:12
@Callisto13 Callisto13 marked this pull request as ready for review December 6, 2021 13:16
@Callisto13 Callisto13 changed the title [WIP] Add action to bump version of firecracker in e2es chore(deps): Add action to bump version of firecracker in e2es Dec 6, 2021
jmickey
jmickey previously approved these changes Dec 6, 2021
Note: The firecracker version included in the bootstrap.sh of this PR
is a dummy version so I can see that everything works.

The action will open a PR to bump the version when a new one is
available.
The new firecracker release wont actually exist yet, as there are some
manual steps required to update the macvtap feature branch on our fork.
These manual steps will be detailed in the PR.
@Callisto13 Callisto13 merged commit 51dc7e8 into main Dec 7, 2021
@Callisto13 Callisto13 deleted the bump-fork branch December 7, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/firecracker Indicates an issue or PR related to Firecracker area/testing Indicates an issue related to test kind/feature New feature or request size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants