Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test is executed for missing packages #264

Open
patric-eberle opened this issue Feb 7, 2023 · 3 comments
Open

Test is executed for missing packages #264

patric-eberle opened this issue Feb 7, 2023 · 3 comments
Assignees

Comments

@patric-eberle
Copy link

The npq tests are also executed for packages, that don't exists.

grafik

Expected Behavior

I would recommend to throw an exception in this case. Package does not exist

Current Behavior

A package check is displayed with some checks even succeed.

Possible Solution

Show an error message if package can not be found in registries.

Steps to Reproduce (for bugs)

  1. run npm i --save-dev @types/vite-plugin-image-optimizer

Context

Your Environment

  • Version used: 2.20.0
  • Environment name and version (e.g. Chrome 39, Node.js 5.4): Node 18
  • Operating System and version (desktop or mobile): macOS Ventura
  • Link to your project:
@lirantal lirantal self-assigned this Feb 7, 2023
@lirantal
Copy link
Owner

lirantal commented Feb 7, 2023

@patric-eberle that's a good point. thanks!
would you like to send a PR for this? no stress, just making sure you're able to run it

@komura-c
Copy link

@lirantal
can i try this?

@lirantal
Copy link
Owner

@komura-c sure but could you please proposal in what way you'd like to implement it first? I feel like if this is probably shouldn't be a marshall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants