-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookie banner and enable gtag #922
Conversation
I think it looks a bit weird on the playground and tutorials pages, because the background color is the same as the one on that page. What if it was black? |
A shadow could also help. The one at https://web.dev/ is black with shadow. |
OMG TESTS PASS! I've also added a screenshot test for the banner. Also added Material elevation 5 following material.io's recommendation for material 2 snackbars |
Curious where did the language for this come from? The web.dev one is "We serve cookies on this site to analyze traffic, remember your preferences, and optimize your experience." |
How did black look? |
Yes. Do we need to say cookies from Google? |
packages/lit-dev-content/src/components/litdev-cookie-banner.ts
Outdated
Show resolved
Hide resolved
We finally got the go-ahead from launch review |
packages/lit-dev-content/src/components/litdev-cookie-banner.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Marks <aomarks@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screenshot needs updating I assume?
IDK why the tests keep getting cancelled |
test failures are from another PR that got into main. Will fix in followup |
Fixes #932
We should first enable page count analtics
Links to test:
light bg:
https://pr922-8f2ca78---lit-dev-5ftespv5na-uc.a.run.app/
dark bg:
https://pr922-8f2ca78---lit-dev-5ftespv5na-uc.a.run.app/playground
https://pr922-8f2ca78---lit-dev-5ftespv5na-uc.a.run.app/tutorials/intro-to-lit
Followed semantics and DOM structure of the angular and firebase ones