Update rethink scroll to #3482

graynorton · 2022-11-29T13:32:08Z

Merge changes from main into rethink-scroll-to

* Move the render function to the end of lit-html Believe it or not, this is part of some work to better integrate with closure compiler's dead code elimination. * Add an empty changeset. * Fix empty changeset.

…#3291) Add intersection controller and performance controller tests to CI - skipping Safari. Deflake Firefox intersection controller tests.

…after host connected (#3293) Co-authored-by: Steve Orvell <sorvell@google.com>

…3288) * Refactor context * Make Analyzer implement AnalyzerInterface rather than has-a AnalyzerContext * Add PackageInfo and pass to getModule * Add changeset. Minor cleanup. * Fix cli test * Normalize rootDir * Refactor PackageAnalyzer into factory * Address feedback. Minor cleanup.

…es (#3310) * test-output points to the same react dependency * remove types from tsconfig in labs_react * restore multiple react versions

* [cli] Lazily install and locally version localize Also merge the two localize commands into one They have just about the same deps and share some setup and teardown code, there's no win in putting them in separate modules. * Use better assertions of no errors. This should print out the stderr output in the case there was some. * Fix error output The .finally fork of the Promise.race result promise was causing an early exit from node before the ordinary uvu error handling could kick in. * Fix failing test It was passing locally because the cwd was set to the CLI directory, but we want to run in a fake workspace directory. * Add an installation message when running npm install. * Changeset * Use try/finally instead of promise methods * Move localize command into its own package.

Adds an `isServer` variable export to `lit` and `lit-html/is-server.js` which will be `true` in Node and `false` in the browser. This can be used when authoring components to change behavior based on whether or not the component is executing in an SSR context.

* Add support for analyzing JavaScript packages * Fix customElements.define detection, add comments. * Better comments / error handling * Revert accidental SSR changes * Add optional/non-null to model * Run analyzer_test in JS. Add changeset. * Fix gen-wrapper-angular * Fix another inadvertant SSR change * Address review feedback. * Add test based on feedback.

…ic (#3294) Fix value property of type `unknown` on exported controllers. The type of `value` is now generic and can be inferred from the return type of your passed in `callback`. The default callback `() => true` was removed, and is now undefined by default.

* create params object * add changeset * update readme * eeek, this requires generics * found correct return type * more refined type * add ref typing * adjust ref typings * type forwarded instance * expose types at top of file * organize types * no react window module * no react window module * add event listeners * checkout readmes from main * remove as casting in render * remove anys * create minimal JSXInterface for library * save types * jsxmodule * attrubtes over htmlprops * explicit return of element types * move comments * minimal references to window * remove ref cast * remove code changes, type only changes * update changeset * ideal * roll back to minimal amount of changes * types at top of file * better comment * rename userprops to element props * add types to test refs * add extends to exported element props type * pause to sync * add comments, more specific names for events * update EventNames downstream * include package types in tsconfig * undo * tests pass with no extra exports * exposing element props successful * wow only the exposed ReactWebComponent fails * add react types to workspaces * move types to dev deps * remove artifacts from different PR * remove rollup artifact from other PR * declare types in test-output tsconfig * capitals for classes * add export to ReactWebComponent * a/b the types array in test-output * add test for ReactWebComponent type * simplify test * componentProps to ReactComponentProps * type only test * update description * unblocked gen-wrapper-react * add comment for type test * restore modified files * restore modified files, again * remove types tsconfig property * only export what's required * remove old code * add return type * remove extra line in index

…connected (#3321) Controllers now track all observed targets and will restore observing targets when host is reconnected. Fixes: #2902

…ctionController (#3323) Add unobserve method to `ResizeController` and `IntersectionController` to match native API. Fixes: #3237

* Update changesets for release * Update cli-localize package.json for release * Add @lit-labs/cli-localize to changeset

* create params object * add changeset * update readme * eeek, this requires generics * found correct return type * more refined type * add ref typing * adjust ref typings * type forwarded instance * expose types at top of file * organize types * no react window module * no react window module * more merge main * initial params bag * add changeset, remove commented code * ReactOrParams * destructure params * update tests, react is optional * remove optional react * remove default react * change is a patch * forgot options.react

* initial commit * add empty changeset

* [gen-manifest] Initial impl of CEM generator Reset changelog Fix readme * Sync with monorepo changes * Fix comments * Add variable declaration * Update to changes on main. * Fix version for gen-utils * Fix analyzer version * Fix and add tests for type reference serialization

* Cache Module models based on dependencies. * Cleanup and add changeset. * Windows path fixes * Normalize all the paths for Windows * Move moduleCache from module var to Analyzer field. * Add missing wireit input * Add missing wireit output

) Initializers are copied but separate from superclass initializers, fixes #/3373.

I changed the h3 tag to be an h1 tag to match the other routes

* Update chromedriver to 107 for benchmark tests

…3424) * Added a test to demonstrate virtualizer width inheritance bug in #3400 * Applied the fix to Virtualizer _updateView to interpret width correctly. * Added changeset describing the fix for #3400.

* Added an events.js to export the RangeChangedEvent and VisibilityChangedEvent classes. * Point to events.js to get the event classes now and moved the custom Range interface into there. * Added events.js files to package.json's files property and the wireit outputs for build:ts.

* [labs/react] Filter __forwardedRef in prod build * rebased from main, branched from react-forwarded-ref * added changeset * update ref setting * add dunders back in * add comments, update changeset * iterrate userprops Co-authored-by: Justin Fagnani <justinfagnani@google.com>

…oot (#3434)

* Fix dep on missing folder. Fixes npm install on npm 9. * Add empty changeset

Co-authored-by: Justin Fagnani <justinfagnani@google.com>

* Update logo.svg * empty changeset * lit logo dark mode * add light theme too * fix file locations * use srcset * slack to discord badge

* Gitignore build output files from virtualizer * add prettierignore files

…g, and Superclass support (#3380) * Fix comment * Use NODE_OPTIONS=--enable-source-maps * Make declarations lazy * Analyze exports and add ability to dereference References to them * Add superClass reference analysis * Add changeset * fixup! Use NODE_OPTIONS=--enable-source-maps * Fix references to ImportTypes * Add CEM generation to CLI * Fix type import references * Address review feedback. * Fix path normalization on Windows * Updates based on feedback. * Add getSpecifierString to another site.

…rator (#3464) * Adds exports to manifest generator Also fixes a few bugs in export analysis and adds better tests. * Add `@slot`, `@cssProp`, and `@cssPart` to manifest generator * Fix config to make JS program analysis faster. * Add windows line ending to regex * Add changeset * Additional Windows line endings fix. * Add support for parsing description, summary, & deprecated * Add more exports support * Emit summary & description in manifest.

* Gitignore build output files from virtualizer * add prettierignore files

changeset-bot · 2022-11-29T13:32:11Z

🦋 Changeset detected

Latest commit: 46ba5c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@lit-labs/context	Minor
@lit-labs/analyzer	Minor
@lit-labs/gen-manifest	Minor
@lit-labs/cli	Minor
@lit-labs/react	Patch
@lit-labs/gen-utils	Minor
@lit-labs/gen-wrapper-angular	Patch
@lit-labs/gen-wrapper-react	Patch
@lit-labs/gen-wrapper-vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-cla · 2022-11-29T13:32:17Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

github-actions · 2022-11-29T13:32:32Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -1% - +6% (-0.22ms - +1.23ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 79.25ms - 81.36ms
lit-html-kitchen-sink: unsure 🔍 -5% - +2% (-1.46ms - +0.58ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -5% - +4% (-0.60ms - +0.51ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +1% (-1.39ms - +0.42ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -3% - +2% (-1.69ms - +0.83ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 660.56ms - 668.21ms
lit-html-kitchen-sink: slower ❌ 1% - 9% (0.61ms - 7.11ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -13% - +8% (-39.84ms - +25.14ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.60ms - +1.82ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-3.50ms - +3.56ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 670.35ms - 675.34ms
reactive-element-list: unsure 🔍 -0% - +1% (-2.99ms - +8.05ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 107.0.5304.110
Sample size: 50
Built by: Benchmarks #4107
Commit: bce9554

render

Version	Avg time	vs
	79.25ms - 81.36ms	-

update

Version	Avg time	vs
	660.56ms - 668.21ms	-

update-reflect

Version	Avg time	vs
	670.35ms - 675.34ms	-

lit-html-kitchen-sink

Browser: chrome-headless 107.0.5304.110
Sample size: 30
Built by: Benchmarks #4107
Commit: bce9554

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	30.52ms - 31.95ms	-	unsure 🔍 -5% - +2% -1.46ms - +0.58ms	unsure 🔍 -2% - +4% -0.56ms - +1.37ms
tip-of-tree tip-of-tree	30.95ms - 32.40ms	unsure 🔍 -2% - +5% -0.58ms - +1.46ms	-	unsure 🔍 -0% - +6% -0.12ms - +1.82ms
previous-release previous-release	30.18ms - 31.47ms	unsure 🔍 -4% - +2% -1.37ms - +0.56ms	unsure 🔍 -6% - +0% -1.82ms - +0.12ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	80.14ms - 84.65ms	-	slower ❌ 1% - 9% 0.61ms - 7.11ms	unsure 🔍 -3% - +4% -2.64ms - +3.08ms
tip-of-tree tip-of-tree	76.19ms - 80.87ms	faster ✔ 1% - 9% 0.61ms - 7.11ms	-	faster ✔ 1% - 8% 0.71ms - 6.57ms
previous-release previous-release	80.41ms - 83.93ms	unsure 🔍 -4% - +3% -3.08ms - +2.64ms	slower ❌ 1% - 8% 0.71ms - 6.57ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	21.72ms - 22.85ms	-	unsure 🔍 -1% - +6% -0.22ms - +1.23ms	unsure 🔍 -1% - +5% -0.32ms - +1.01ms
tip-of-tree tip-of-tree	21.33ms - 22.23ms	unsure 🔍 -5% - +1% -1.23ms - +0.22ms	-	unsure 🔍 -3% - +2% -0.73ms - +0.41ms
previous-release previous-release	21.58ms - 22.29ms	unsure 🔍 -5% - +1% -1.01ms - +0.32ms	unsure 🔍 -2% - +3% -0.41ms - +0.73ms	-

lit-html-repeat

Browser: chrome-headless 107.0.5304.110
Sample size: 30
Built by: Benchmarks #4107
Commit: bce9554

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.29ms - 12.13ms	-	unsure 🔍 -5% - +4% -0.60ms - +0.51ms	unsure 🔍 -6% - +4% -0.71ms - +0.44ms
tip-of-tree tip-of-tree	11.39ms - 12.12ms	unsure 🔍 -4% - +5% -0.51ms - +0.60ms	-	unsure 🔍 -5% - +4% -0.63ms - +0.45ms
previous-release previous-release	11.45ms - 12.23ms	unsure 🔍 -4% - +6% -0.44ms - +0.71ms	unsure 🔍 -4% - +5% -0.45ms - +0.63ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	272.97ms - 314.45ms	-	unsure 🔍 -13% - +8% -39.84ms - +25.14ms	unsure 🔍 -14% - +10% -41.56ms - +29.77ms
tip-of-tree tip-of-tree	276.05ms - 326.08ms	unsure 🔍 -9% - +14% -25.14ms - +39.84ms	-	unsure 🔍 -12% - +13% -36.86ms - +39.76ms
previous-release previous-release	270.59ms - 328.63ms	unsure 🔍 -10% - +14% -29.77ms - +41.56ms	unsure 🔍 -13% - +12% -39.76ms - +36.86ms	-

lit-html-template-heavy

Browser: chrome-headless 107.0.5304.110
Sample size: 50
Built by: Benchmarks #4107
Commit: bce9554

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	52.13ms - 53.37ms	-	unsure 🔍 -3% - +1% -1.39ms - +0.42ms	unsure 🔍 -4% - +0% -1.93ms - +0.14ms
tip-of-tree tip-of-tree	52.58ms - 53.88ms	unsure 🔍 -1% - +3% -0.42ms - +1.39ms	-	unsure 🔍 -3% - +1% -1.47ms - +0.65ms
previous-release previous-release	52.81ms - 54.47ms	unsure 🔍 -0% - +4% -0.14ms - +1.93ms	unsure 🔍 -1% - +3% -0.65ms - +1.47ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	104.07ms - 106.11ms	-	unsure 🔍 -1% - +2% -0.60ms - +1.82ms	unsure 🔍 -1% - +2% -1.02ms - +1.65ms
tip-of-tree tip-of-tree	103.82ms - 105.14ms	unsure 🔍 -2% - +1% -1.82ms - +0.60ms	-	unsure 🔍 -1% - +1% -1.38ms - +0.79ms
previous-release previous-release	103.91ms - 105.64ms	unsure 🔍 -2% - +1% -1.65ms - +1.02ms	unsure 🔍 -1% - +1% -0.79ms - +1.38ms	-

reactive-element-list

Browser: chrome-headless 107.0.5304.110
Sample size: 50
Built by: Benchmarks #4107
Commit: bce9554

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	52.01ms - 53.65ms	-	unsure 🔍 -3% - +2% -1.69ms - +0.83ms	unsure 🔍 -3% - +2% -1.71ms - +0.87ms
tip-of-tree tip-of-tree	52.30ms - 54.22ms	unsure 🔍 -2% - +3% -0.83ms - +1.69ms	-	unsure 🔍 -3% - +3% -1.37ms - +1.39ms
previous-release previous-release	52.26ms - 54.24ms	unsure 🔍 -2% - +3% -0.87ms - +1.71ms	unsure 🔍 -3% - +3% -1.39ms - +1.37ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	657.49ms - 662.36ms	-	unsure 🔍 -1% - +1% -3.50ms - +3.56ms	unsure 🔍 -0% - +1% -2.74ms - +3.97ms
tip-of-tree tip-of-tree	657.34ms - 662.45ms	unsure 🔍 -1% - +1% -3.56ms - +3.50ms	-	unsure 🔍 -0% - +1% -2.86ms - +4.03ms
previous-release previous-release	657.00ms - 661.61ms	unsure 🔍 -1% - +0% -3.97ms - +2.74ms	unsure 🔍 -1% - +0% -4.03ms - +2.86ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	685.70ms - 695.83ms	-	unsure 🔍 -0% - +1% -2.99ms - +8.05ms	unsure 🔍 -1% - +1% -3.91ms - +7.26ms
tip-of-tree tip-of-tree	686.03ms - 690.43ms	unsure 🔍 -1% - +0% -8.05ms - +2.99ms	-	unsure 🔍 -1% - +0% -4.07ms - +2.36ms
previous-release previous-release	686.74ms - 691.43ms	unsure 🔍 -1% - +1% -7.26ms - +3.91ms	unsure 🔍 -0% - +1% -2.36ms - +4.07ms	-

_{tachometer-reporter-action v2 for Benchmarks}

usergenic

LGTM

usergenic · 2022-11-30T00:59:51Z

Merging now as after testing locally it's still the same 4 direction:horizontal scroller:true cases that are failing, so this introduces no issues.

rictic and others added 30 commits September 9, 2022 16:00

Move the render function to the end of lit-html (#3284)

426b4d8

* Move the render function to the end of lit-html Believe it or not, this is part of some work to better integrate with closure compiler's dead code elimination. * Add an empty changeset. * Fix empty changeset.

Task: Do not reset task value or error on pending (#3283)

a279803

[infra] Enable IntersectionController and PerformanceController tests (…

2994a96

…#3291) Add intersection controller and performance controller tests to CI - skipping Safari. Deflake Firefox intersection controller tests.

[labs/ssr] fix Hydrating LitElements example markup (#3298)

d8aead0

[labs/observers] Fix controllers not observing target if initialized …

7e22bc2

…after host connected (#3293) Co-authored-by: Steve Orvell <sorvell@google.com>

Slack -> Discord readme (#3307)

55ae64a

[@labs/gen-wrapper-react] TestOutput links to monorepo for dependenci…

b225bd3

…es (#3310) * test-output points to the same react dependency * remove types from tsconfig in labs_react * restore multiple react versions

Task add onComplete and onError (#3287)

02b0b7b

[lit] Add "types" to package exports (#3320)

305852d

[labs/observers] observed targets are re-observed when the host is re…

e90e8fe

…connected (#3321) Controllers now track all observed targets and will restore observing targets when host is reconnected. Fixes: #2902

[labs/observers] Add unobserve method to ResizeController and Interse…

0f787b2

…ctionController (#3323) Add unobserve method to `ResizeController` and `IntersectionController` to match native API. Fixes: #3237

[labs/gen-utils] Add core packages to testing install with link (#3330)

75a2afb

[infra] Update changesets and package for release (#3332)

facde0b

* Update changesets for release * Update cli-localize package.json for release * Add @lit-labs/cli-localize to changeset

Remove gen-wrapper-angular from changesets (#3336)

f6919dd

Version Packages (#3337)

1e1e2e0

Unpin Node version for windows-tools test (#3338)

9e978a0

[labs/react] Update REAMDE for function overload (#3350)

a432c38

* initial commit * add empty changeset

[@lit-labs/router] add Routes.link tests (#3348)

2906369

Fix typo in task README (#3385)

7d7fc85

Initializers are copied but separate from superclass initializers (#3374

bb09895

) Initializers are copied but separate from superclass initializers, fixes #/3373.

Example code had an h1 tag closed by an h3 tag (#3392)

fc1f649

I changed the h3 tag to be an h1 tag to match the other routes

augustjk and others added 20 commits November 3, 2022 17:20

[infra] Use new projectV2 object in issue workflow (#3419)

31519e5

Add lit to changeset along side reactive-element (#3422)

d75178c

Version Packages (#3423)

02c2839

Update chromedriver to 107 for benchmark tests (#3427)

4c1915e

* Update chromedriver to 107 for benchmark tests

[labs/virtualizer] Fix width inheritance calculation (issue #3400) (#…

005c68f

…3424) * Added a test to demonstrate virtualizer width inheritance bug in #3400 * Applied the fix to Virtualizer _updateView to interpret width correctly. * Added changeset describing the fix for #3400.

[labs/context] Rename context decorators to consume and provide (#3398)

50f2e42

[labs/context] Make @consume decorator work with optional fields (#3399)

0e52919

[labs/context] Rename ContextKey to Context (#3404)

b3e8993

Allow ContextProvider to be added lazily and still work with ContextR…

a6a5591

…oot (#3434)

[infra] Fix npm install with version 9 (#3448)

cce4629

* Fix dep on missing folder. Fixes npm install on npm 9. * Add empty changeset

Implement lit init element (#3248)

9b9bdb0

Co-authored-by: Justin Fagnani <justinfagnani@google.com>

Logo dark mode support (#3457)

209cfe0

* Update logo.svg * empty changeset * lit logo dark mode * add light theme too * fix file locations * use srcset * slack to discord badge

Gitignore build output files from virtualizer (#3454)

3ab7a81

* Gitignore build output files from virtualizer * add prettierignore files

Gitignore build output files from virtualizer (#3454)

a544de7

* Gitignore build output files from virtualizer * add prettierignore files

Add the js.map extension to the files property for events.js.

7f002ff

Merge branch 'main' into update-rethink-scroll-to

6f260ff

graynorton requested a review from usergenic November 29, 2022 13:32

graynorton requested a review from justinfagnani as a code owner November 29, 2022 13:32

update .prettierignore and .gitignore to include events.js.map

46ba5c1

usergenic approved these changes Nov 30, 2022

View reviewed changes

usergenic merged commit 403997b into rethink-scroll-to Nov 30, 2022

usergenic deleted the update-rethink-scroll-to branch November 30, 2022 01:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rethink scroll to #3482

Update rethink scroll to #3482

graynorton commented Nov 29, 2022

changeset-bot bot commented Nov 29, 2022 •

edited

google-cla bot commented Nov 29, 2022

github-actions bot commented Nov 29, 2022 •

edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

usergenic left a comment

usergenic commented Nov 30, 2022

Update rethink scroll to #3482

Update rethink scroll to #3482

Conversation

graynorton commented Nov 29, 2022

changeset-bot bot commented Nov 29, 2022 • edited

🦋 Changeset detected

google-cla bot commented Nov 29, 2022

github-actions bot commented Nov 29, 2022 • edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

usergenic left a comment

Choose a reason for hiding this comment

usergenic commented Nov 30, 2022

changeset-bot bot commented Nov 29, 2022 •

edited

github-actions bot commented Nov 29, 2022 •

edited