[labs/react] introduce a options object #2988

taylor-vann · 2022-06-04T00:12:16Z

This PR introduces a params object for the @labs/react package.

Why

API functions that rely on 3+ arguments are typically more difficult to extend as a library matures.

Mainly, param objects eliminate ordering as a concern as well as prevent passing undefined as an argument.
ie:

const MyComponent = createComponent(
  React,
  'tag-name',
  MyElement,
  undefined,
  undefined,
  newFeatureArg,
);

Since createComponent is called once per component in an application, creating an params object once per component is not very expensive.

How

The params object looks like this:

interface Options<I extends HTMLElement, E extends Events = {}> {
  React: typeof window.React;
  tagName: string;
  elementClass: Constructor<I>;
  events?: E;
  displayName?: string;
}

But it could use some review, probably better names.

changeset-bot · 2022-06-04T00:12:18Z

🦋 Changeset detected

Latest commit: 034b682

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-06-04T00:12:43Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -2% - +5% (-0.63ms - +1.50ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 115.05ms - 119.88ms
lit-html-kitchen-sink: unsure 🔍 -5% - +1% (-2.08ms - +0.56ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -3% - +5% (-0.38ms - +0.66ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +1% (-2.37ms - +0.87ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -3% - +1% (-2.45ms - +1.07ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 1142.39ms - 1156.46ms
lit-html-kitchen-sink: unsure 🔍 -3% - +4% (-3.21ms - +5.10ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +3% (-2.03ms - +10.45ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +1% (-3.70ms - +2.43ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-17.11ms - +11.08ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 1144.96ms - 1157.50ms
reactive-element-list: unsure 🔍 -0% - +1% (-3.34ms - +18.06ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 106.0.5249.91
Sample size: 50
Built by: Benchmarks #3923
Commit: a03195d

render

Version	Avg time	vs
	115.05ms - 119.88ms	-

update

Version	Avg time	vs
	1142.39ms - 1156.46ms	-

update-reflect

Version	Avg time	vs
	1144.96ms - 1157.50ms	-

lit-html-kitchen-sink

Browser: chrome-headless 106.0.5249.91
Sample size: 30
Built by: Benchmarks #3923
Commit: a03195d

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	43.92ms - 45.77ms	-	unsure 🔍 -5% - +1% -2.08ms - +0.56ms	unsure 🔍 -4% - +2% -1.90ms - +0.74ms
tip-of-tree tip-of-tree	44.67ms - 46.54ms	unsure 🔍 -1% - +5% -0.56ms - +2.08ms	-	unsure 🔍 -3% - +3% -1.14ms - +1.50ms
previous-release previous-release	44.49ms - 46.36ms	unsure 🔍 -2% - +4% -0.74ms - +1.90ms	unsure 🔍 -3% - +3% -1.50ms - +1.14ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	120.74ms - 126.61ms	-	unsure 🔍 -3% - +4% -3.21ms - +5.10ms	unsure 🔍 -2% - +4% -2.80ms - +5.34ms
tip-of-tree tip-of-tree	119.78ms - 125.67ms	unsure 🔍 -4% - +3% -5.10ms - +3.21ms	-	unsure 🔍 -3% - +4% -3.75ms - +4.40ms
previous-release previous-release	119.58ms - 125.22ms	unsure 🔍 -4% - +2% -5.34ms - +2.80ms	unsure 🔍 -4% - +3% -4.40ms - +3.75ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	30.60ms - 32.30ms	-	unsure 🔍 -2% - +5% -0.63ms - +1.50ms	unsure 🔍 -1% - +6% -0.21ms - +1.83ms
tip-of-tree tip-of-tree	30.36ms - 31.66ms	unsure 🔍 -5% - +2% -1.50ms - +0.63ms	-	unsure 🔍 -2% - +4% -0.48ms - +1.23ms
previous-release previous-release	30.08ms - 31.19ms	unsure 🔍 -6% - +1% -1.83ms - +0.21ms	unsure 🔍 -4% - +2% -1.23ms - +0.48ms	-

lit-html-repeat

Browser: chrome-headless 106.0.5249.91
Sample size: 30
Built by: Benchmarks #3923
Commit: a03195d

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.41ms - 14.37ms	-	unsure 🔍 -3% - +5% -0.38ms - +0.66ms	unsure 🔍 -4% - +4% -0.54ms - +0.59ms
tip-of-tree tip-of-tree	13.55ms - 13.95ms	unsure 🔍 -5% - +3% -0.66ms - +0.38ms	-	unsure 🔍 -3% - +2% -0.47ms - +0.25ms
previous-release previous-release	13.56ms - 14.16ms	unsure 🔍 -4% - +4% -0.59ms - +0.54ms	unsure 🔍 -2% - +3% -0.25ms - +0.47ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	381.46ms - 389.77ms	-	unsure 🔍 -1% - +3% -2.03ms - +10.45ms	unsure 🔍 -1% - +2% -4.01ms - +8.55ms
tip-of-tree tip-of-tree	376.75ms - 386.05ms	unsure 🔍 -3% - +1% -10.45ms - +2.03ms	-	unsure 🔍 -2% - +1% -8.56ms - +4.68ms
previous-release previous-release	378.63ms - 388.06ms	unsure 🔍 -2% - +1% -8.55ms - +4.01ms	unsure 🔍 -1% - +2% -4.68ms - +8.56ms	-

lit-html-template-heavy

Browser: chrome-headless 106.0.5249.91
Sample size: 50
Built by: Benchmarks #3923
Commit: a03195d

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	75.81ms - 78.10ms	-	unsure 🔍 -3% - +1% -2.37ms - +0.87ms	unsure 🔍 -1% - +3% -0.72ms - +2.32ms
tip-of-tree tip-of-tree	76.56ms - 78.85ms	unsure 🔍 -1% - +3% -0.87ms - +2.37ms	-	slower ❌ 0% - 4% 0.02ms - 3.07ms
previous-release previous-release	75.15ms - 77.16ms	unsure 🔍 -3% - +1% -2.32ms - +0.72ms	faster ✔ 0% - 4% 0.02ms - 3.07ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	167.60ms - 172.80ms	-	unsure 🔍 -2% - +1% -3.70ms - +2.43ms	unsure 🔍 -2% - +2% -3.57ms - +2.67ms
tip-of-tree tip-of-tree	169.22ms - 172.46ms	unsure 🔍 -1% - +2% -2.43ms - +3.70ms	-	unsure 🔍 -1% - +1% -2.18ms - +2.56ms
previous-release previous-release	168.93ms - 172.37ms	unsure 🔍 -2% - +2% -2.67ms - +3.57ms	unsure 🔍 -1% - +1% -2.56ms - +2.18ms	-

reactive-element-list

Browser: chrome-headless 106.0.5249.91
Sample size: 50
Built by: Benchmarks #3923
Commit: a03195d

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	78.25ms - 80.75ms	-	unsure 🔍 -3% - +1% -2.45ms - +1.07ms	unsure 🔍 -4% - +0% -3.15ms - +0.36ms
tip-of-tree tip-of-tree	78.96ms - 81.43ms	unsure 🔍 -1% - +3% -1.07ms - +2.45ms	-	unsure 🔍 -3% - +1% -2.45ms - +1.04ms
previous-release previous-release	79.67ms - 82.13ms	unsure 🔍 -0% - +4% -0.36ms - +3.15ms	unsure 🔍 -1% - +3% -1.04ms - +2.45ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1164.80ms - 1185.96ms	-	unsure 🔍 -1% - +1% -17.11ms - +11.08ms	unsure 🔍 -2% - +1% -20.68ms - +8.61ms
tip-of-tree tip-of-tree	1169.08ms - 1187.71ms	unsure 🔍 -1% - +1% -11.08ms - +17.11ms	-	unsure 🔍 -1% - +1% -16.78ms - +10.74ms
previous-release previous-release	1171.29ms - 1191.55ms	unsure 🔍 -1% - +2% -8.61ms - +20.68ms	unsure 🔍 -1% - +1% -10.74ms - +16.78ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1209.64ms - 1223.49ms	-	unsure 🔍 -0% - +1% -3.34ms - +18.06ms	slower ❌ 0% - 2% 3.27ms - 23.88ms
tip-of-tree tip-of-tree	1201.05ms - 1217.36ms	unsure 🔍 -1% - +0% -18.06ms - +3.34ms	-	unsure 🔍 -0% - +1% -4.95ms - +17.38ms
previous-release previous-release	1195.37ms - 1210.62ms	faster ✔ 0% - 2% 3.27ms - 23.88ms	unsure 🔍 -1% - +0% -17.38ms - +4.95ms	-

_{tachometer-reporter-action v2 for Benchmarks}

taylor-vann · 2022-06-06T17:09:28Z

ah gen-wrapper-react needs to be updated

justinfagnani · 2022-06-06T17:32:11Z

packages/labs/react/src/create-component.ts

-  events?: E,
-  displayName?: string
-) => {
+export const createComponent = <I extends HTMLElement, E extends Events>({


Let's make this new signature an additive and non-breaking change by duck-typing. Keep the old signature as an override and add the new signature as an override. Make the base function signature take a typeof ReactModule | CreateComponentParams<I, E> as the first argument called optionsOrReact, and tagName?, etc as the remaining argument. If tagName is a string, assume the first argument is a React module, if tagName is undefined, the first argument is a options object.

ill give it a try! thanks @justinfagnani

I'm having trouble differentiating between ReactModule and CreateComponentParams.

Differentiate the two signatures by looking for the second parameter - tagName. If it's a string you have a legacy positional params call and the first param is the React module, if it's undefined you have a new options object style call and the first param is the options object.

taylor-vann · 2022-07-19T17:20:12Z

Coming back to this, I still think a params object is a good idea for future-proofing the library.

Caveat is, we're gonna need to define what we are returning in each overload. It wasn't super obvious although i narrowed it down to ForwardRefRenderFunction

However this typing causes two type errors inferring certain properties on test elements, more exploration required. Might give this a solid day or two to figure out

justinfagnani · 2022-07-19T19:43:13Z

Isn't the return type just Component<ComponentProps>? (ie, ForwardRef shouldn't change the external type). Can we just extract this into a helper type?:

  // Props the user is allowed to use, includes standard attributes, children,
  // ref, as well as special event and element properties.
  type ReactProps = Omit<React.HTMLAttributes<I>, keyof E>;
  type ElementWithoutPropsOrEvents = Omit<I, keyof E | keyof ReactProps>;
  type UserProps = Partial<
    ReactProps & ElementWithoutPropsOrEvents & EventProps<E>
  >;

  // Props used by this component wrapper. This is the UserProps and the
  // special `__forwardedRef` property. Note, this ref is special because
  // it's both needed in this component to get access to the rendered element
  // and must fulfill any ref passed by the user.
  type ComponentProps = UserProps & {
    __forwardedRef?: React.Ref<unknown>;
  };

taylor-vann · 2022-07-19T23:20:29Z

@justinfagnani will def try! Dunno why I got stuck on a 1:1 typing. You're correct that should work!

justinfagnani · 2022-10-11T21:41:53Z

packages/labs/react/src/create-component.ts

+interface Options<I extends HTMLElement, E extends EventNames = {}> {
+  tagName: string;
+  elementClass: Constructor<I>;
+  React: typeof window.React;


React -> react

* Move the render function to the end of lit-html (#3284) * Move the render function to the end of lit-html Believe it or not, this is part of some work to better integrate with closure compiler's dead code elimination. * Add an empty changeset. * Fix empty changeset. * Task: Do not reset task value or error on pending (#3283) * [infra] Enable IntersectionController and PerformanceController tests (#3291) Add intersection controller and performance controller tests to CI - skipping Safari. Deflake Firefox intersection controller tests. * [labs/ssr] fix Hydrating LitElements example markup (#3298) * [labs/observers] Fix controllers not observing target if initialized after host connected (#3293) Co-authored-by: Steve Orvell <sorvell@google.com> * [labs/analyzer] Refactor Analyzer into better fit for use in plugins (#3288) * Refactor context * Make Analyzer implement AnalyzerInterface rather than has-a AnalyzerContext * Add PackageInfo and pass to getModule * Add changeset. Minor cleanup. * Fix cli test * Normalize rootDir * Refactor PackageAnalyzer into factory * Address feedback. Minor cleanup. * Slack -> Discord readme (#3307) * [@labs/gen-wrapper-react] TestOutput links to monorepo for dependencies (#3310) * test-output points to the same react dependency * remove types from tsconfig in labs_react * restore multiple react versions * [labs/cli] Lazily install and locally version localize (#2936) * [cli] Lazily install and locally version localize Also merge the two localize commands into one They have just about the same deps and share some setup and teardown code, there's no win in putting them in separate modules. * Use better assertions of no errors. This should print out the stderr output in the case there was some. * Fix error output The .finally fork of the Promise.race result promise was causing an early exit from node before the ordinary uvu error handling could kick in. * Fix failing test It was passing locally because the cwd was set to the CLI directory, but we want to run in a fake workspace directory. * Add an installation message when running npm install. * Changeset * Use try/finally instead of promise methods * Move localize command into its own package. * Task add onComplete and onError (#3287) * [lit] Add "types" to package exports (#3320) * [lit-html] Add `isServer` environment checker module (#3318) Adds an `isServer` variable export to `lit` and `lit-html/is-server.js` which will be `true` in Node and `false` in the browser. This can be used when authoring components to change behavior based on whether or not the component is executing in an SSR context. * [labs/analyzer] Adds support for analyzing JavaScript packages (#3304) * Add support for analyzing JavaScript packages * Fix customElements.define detection, add comments. * Better comments / error handling * Revert accidental SSR changes * Add optional/non-null to model * Run analyzer_test in JS. Add changeset. * Fix gen-wrapper-angular * Fix another inadvertant SSR change * Address review feedback. * Add test based on feedback. * [labs/observers] Improve controllers value type from unknown to generic (#3294) Fix value property of type `unknown` on exported controllers. The type of `value` is now generic and can be inferred from the return type of your passed in `callback`. The default callback `() => true` was removed, and is now undefined by default. * [labs/react] Provide explicit return type from createComponent (#3163) * create params object * add changeset * update readme * eeek, this requires generics * found correct return type * more refined type * add ref typing * adjust ref typings * type forwarded instance * expose types at top of file * organize types * no react window module * no react window module * add event listeners * checkout readmes from main * remove as casting in render * remove anys * create minimal JSXInterface for library * save types * jsxmodule * attrubtes over htmlprops * explicit return of element types * move comments * minimal references to window * remove ref cast * remove code changes, type only changes * update changeset * ideal * roll back to minimal amount of changes * types at top of file * better comment * rename userprops to element props * add types to test refs * add extends to exported element props type * pause to sync * add comments, more specific names for events * update EventNames downstream * include package types in tsconfig * undo * tests pass with no extra exports * exposing element props successful * wow only the exposed ReactWebComponent fails * add react types to workspaces * move types to dev deps * remove artifacts from different PR * remove rollup artifact from other PR * declare types in test-output tsconfig * capitals for classes * add export to ReactWebComponent * a/b the types array in test-output * add test for ReactWebComponent type * simplify test * componentProps to ReactComponentProps * type only test * update description * unblocked gen-wrapper-react * add comment for type test * restore modified files * restore modified files, again * remove types tsconfig property * only export what's required * remove old code * add return type * remove extra line in index * [labs/observers] observed targets are re-observed when the host is reconnected (#3321) Controllers now track all observed targets and will restore observing targets when host is reconnected. Fixes: #2902 * [labs/observers] Add unobserve method to ResizeController and IntersectionController (#3323) Add unobserve method to `ResizeController` and `IntersectionController` to match native API. Fixes: #3237 * [labs/gen-utils] Add core packages to testing install with link (#3330) * [infra] Update changesets and package for release (#3332) * Update changesets for release * Update cli-localize package.json for release * Add @lit-labs/cli-localize to changeset * Remove gen-wrapper-angular from changesets (#3336) * Version Packages (#3337) * Unpin Node version for windows-tools test (#3338) * [labs/react] introduce a options object (#2988) * create params object * add changeset * update readme * eeek, this requires generics * found correct return type * more refined type * add ref typing * adjust ref typings * type forwarded instance * expose types at top of file * organize types * no react window module * no react window module * more merge main * initial params bag * add changeset, remove commented code * ReactOrParams * destructure params * update tests, react is optional * remove optional react * remove default react * change is a patch * forgot options.react * [labs/react] Update REAMDE for function overload (#3350) * initial commit * add empty changeset * [@lit-labs/router] add Routes.link tests (#3348) * [gen-manifest] Initial impl of CEM generator (#2990) * [gen-manifest] Initial impl of CEM generator Reset changelog Fix readme * Sync with monorepo changes * Fix comments * Add variable declaration * Update to changes on main. * Fix version for gen-utils * Fix analyzer version * Fix and add tests for type reference serialization * [labs/analyzer] Cache Module models based on dependencies. (#3333) * Cache Module models based on dependencies. * Cleanup and add changeset. * Windows path fixes * Normalize all the paths for Windows * Move moduleCache from module var to Analyzer field. * Add missing wireit input * Add missing wireit output * Fix typo in task README (#3385) * Initializers are copied but separate from superclass initializers (#3374) Initializers are copied but separate from superclass initializers, fixes #/3373. * Example code had an h1 tag closed by an h3 tag (#3392) I changed the h3 tag to be an h1 tag to match the other routes * Improvements to Vue/React wrappers (#3377) Updates react wrapper to correctly type events Update vue wrapper * update vite/vue deps * properly type events * configure defaults using the Vue convention: whenever unset, revert to default value. * Wrapper test elements + runtime tests (#3384) * Adds additional test elements * element-events: for testing events * element-props: for testing property types * element-slots: for testing slotting. * Adds property types to angular wrapper * [@labs/react] certain attributes should be removed when undefined or null (#3128) * add sieve for boolean attributes * unchange stuff that isn't required yet * add changeset * no sieve, use hasAttribute * use hasOwnProperty * boolean attributes should test as null * pause * let react handle the nullifies * remove unnecessary return * add comment, update changeset * remove 232 * cascade logic over nested * update comments * don't watch for disabled * show test updates and output * hidden attr is alright * passing tests * set HTMLPrototype undefined values to empty string * id is the special case * add tests for properties * update tests for properties * remove nested iffs from set property * format * set as empty string * change value, don't assign * value as str * remove attribute if undefined * set value as string on htmlelement attr * match vanilla react behavior * order ifs by cost, comment alternatives * forgot return * checkpoint * sync with example gist * draggable is null * checkpoint * update tests, wrappedEl vs el * test div against web component * remove extra lines * update changeset * include unwrapped web component x-foo * add null checks at end of attribute checks * add comments, add undefined tests after boolean * typo, enumerated * add null checkes to test, add ts-expect-errors * add test ordering * forgot one truthy test * [infra] Use new projectV2 object in issue workflow (#3419) * Add lit to changeset along side reactive-element (#3422) * Version Packages (#3423) * Update chromedriver to 107 for benchmark tests (#3427) * Update chromedriver to 107 for benchmark tests * [labs/virtualizer] Fix width inheritance calculation (issue #3400) (#3424) * Added a test to demonstrate virtualizer width inheritance bug in #3400 * Applied the fix to Virtualizer _updateView to interpret width correctly. * Added changeset describing the fix for #3400. * [labs/virtualizer] Export event classes through a new events.js (#3430) * Added an events.js to export the RangeChangedEvent and VisibilityChangedEvent classes. * Point to events.js to get the event classes now and moved the custom Range interface into there. * Added events.js files to package.json's files property and the wireit outputs for build:ts. * [labs/context] Rename context decorators to consume and provide (#3398) * [@labs/react] Filter __forwardedRef in prod build (#3409) * [labs/react] Filter __forwardedRef in prod build * rebased from main, branched from react-forwarded-ref * added changeset * update ref setting * add dunders back in * add comments, update changeset * iterrate userprops Co-authored-by: Justin Fagnani <justinfagnani@google.com> * [labs/context] Make @consume decorator work with optional fields (#3399) * [labs/context] Rename ContextKey to Context (#3404) * Allow ContextProvider to be added lazily and still work with ContextRoot (#3434) * [infra] Fix npm install with version 9 (#3448) * Fix dep on missing folder. Fixes npm install on npm 9. * Add empty changeset * Implement `lit init element` (#3248) Co-authored-by: Justin Fagnani <justinfagnani@google.com> * Logo dark mode support (#3457) * Update logo.svg * empty changeset * lit logo dark mode * add light theme too * fix file locations * use srcset * slack to discord badge * Gitignore build output files from virtualizer (#3454) * Gitignore build output files from virtualizer * add prettierignore files * [labs/analyzer] Add lazy Declaration analysis, Reference dereferencing, and Superclass support (#3380) * Fix comment * Use NODE_OPTIONS=--enable-source-maps * Make declarations lazy * Analyze exports and add ability to dereference References to them * Add superClass reference analysis * Add changeset * fixup! Use NODE_OPTIONS=--enable-source-maps * Fix references to ImportTypes * Add CEM generation to CLI * Fix type import references * Address review feedback. * Fix path normalization on Windows * Updates based on feedback. * Add getSpecifierString to another site. * [labs/gen-manifest] Adds `exports` and more metadata to manifest generator (#3464) * Adds exports to manifest generator Also fixes a few bugs in export analysis and adds better tests. * Add `@slot`, `@cssProp`, and `@cssPart` to manifest generator * Fix config to make JS program analysis faster. * Add windows line ending to regex * Add changeset * Additional Windows line endings fix. * Add support for parsing description, summary, & deprecated * Add more exports support * Emit summary & description in manifest. * Gitignore build output files from virtualizer (#3454) * Gitignore build output files from virtualizer * add prettierignore files * Add the js.map extension to the files property for events.js. * update .prettierignore and .gitignore to include events.js.map Co-authored-by: Peter Burns <rictic@google.com> Co-authored-by: Elliott Marquez <5981958+e111077@users.noreply.github.com> Co-authored-by: Andrew Jakubowicz <ajakubowicz@google.com> Co-authored-by: Michael Potter <mgp140@gmail.com> Co-authored-by: Steve Orvell <sorvell@google.com> Co-authored-by: Kevin Schaaf <kschaaf@google.com> Co-authored-by: Brian Taylor Vann <brian.t.vann@gmail.com> Co-authored-by: Augustine Kim <augustinekim@google.com> Co-authored-by: Lit Robot <98060554+lit-robot@users.noreply.github.com> Co-authored-by: Nick Cipriani <nick.cipriani@gmail.com> Co-authored-by: Brendan Baldwin <brendan@usergenic.com> Co-authored-by: Justin Fagnani <justinfagnani@google.com>

create params object

732ec89

add changeset

f23e22f

update readme

45e3574

taylor-vann marked this pull request as ready for review June 4, 2022 00:21

taylor-vann requested a review from justinfagnani as a code owner June 4, 2022 00:21

taylor-vann mentioned this pull request Jun 6, 2022

[labs/react] Make createComponent take an options bag #2996

Closed

justinfagnani requested changes Jun 6, 2022

View reviewed changes

taylor-vann added 2 commits July 18, 2022 15:19

this balooned

121f838

eeek, this requires generics

711d1d3

taylor-vann added 9 commits July 21, 2022 17:12

found correct return type

0e61809

more refined type

f50790b

add ref typing

8b7e1d7

adjust ref typings

1b132e9

type forwarded instance

972f05d

expose types at top of file

7c250a0

organize types

1b840d0

no react window module

3021f08

no react window module

84721c8

taylor-vann marked this pull request as draft July 22, 2022 02:18

taylor-vann mentioned this pull request Aug 25, 2022

[labs/react] Provide explicit return type from createComponent #3163

Merged

taylor-vann added 4 commits September 27, 2022 17:00

merge main

ff32aed

more merge main

d42f69c

merge main

32f3120

initial params bag

ae7ecf2

justinfagnani changed the title ~~[@labs/react] introduce a params object~~ [labs/react] introduce a params object Oct 4, 2022

add changeset, remove commented code

6a9f537

taylor-vann requested a review from sorvell October 4, 2022 21:34

taylor-vann added 3 commits October 4, 2022 14:41

ReactOrParams

6efbdcc

destructure params

9a60bd5

update tests, react is optional

5cf2f60

taylor-vann marked this pull request as ready for review October 5, 2022 19:00

taylor-vann added 2 commits October 6, 2022 12:22

remove optional react

69becf8

remove default react

981b12a

taylor-vann requested a review from kevinpschaaf October 7, 2022 18:06

justinfagnani approved these changes Oct 11, 2022

View reviewed changes

taylor-vann added 3 commits October 12, 2022 11:43

change is a patch

9033c56

Merge branch 'main' into labs_react__create_params_object

e2a67c7

forgot options.react

034b682

taylor-vann changed the title ~~[labs/react] introduce a params object~~ [labs/react] introduce a options object Oct 12, 2022

kevinpschaaf approved these changes Oct 12, 2022

View reviewed changes

taylor-vann merged commit 2d10c26 into main Oct 12, 2022

taylor-vann deleted the labs_react__create_params_object branch October 12, 2022 21:01

lit-robot mentioned this pull request Oct 17, 2022

Version Packages #3369

Closed

This was referenced Nov 3, 2022

Version Packages #3421

Closed

Version Packages #3423

Merged

ajmchambers mentioned this pull request Dec 29, 2022

Update make-react.js script to use new @lit-labs/react createComponent options object shoelace-style/shoelace#1090

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[labs/react] introduce a options object #2988

[labs/react] introduce a options object #2988

taylor-vann commented Jun 4, 2022 •

edited

changeset-bot bot commented Jun 4, 2022 •

edited

github-actions bot commented Jun 4, 2022 •

edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

taylor-vann commented Jun 6, 2022

justinfagnani Jun 6, 2022

taylor-vann Jun 6, 2022

taylor-vann Jun 7, 2022

justinfagnani Jun 8, 2022

taylor-vann commented Jul 19, 2022

justinfagnani commented Jul 19, 2022

taylor-vann commented Jul 19, 2022

justinfagnani Oct 11, 2022

taylor-vann Oct 12, 2022

[labs/react] introduce a options object #2988

[labs/react] introduce a options object #2988

Conversation

taylor-vann commented Jun 4, 2022 • edited

Why

How

changeset-bot bot commented Jun 4, 2022 • edited

🦋 Changeset detected

github-actions bot commented Jun 4, 2022 • edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

taylor-vann commented Jun 6, 2022

justinfagnani Jun 6, 2022

Choose a reason for hiding this comment

taylor-vann Jun 6, 2022

Choose a reason for hiding this comment

taylor-vann Jun 7, 2022

Choose a reason for hiding this comment

justinfagnani Jun 8, 2022

Choose a reason for hiding this comment

taylor-vann commented Jul 19, 2022

justinfagnani commented Jul 19, 2022

taylor-vann commented Jul 19, 2022

justinfagnani Oct 11, 2022

Choose a reason for hiding this comment

taylor-vann Oct 12, 2022

Choose a reason for hiding this comment

taylor-vann commented Jun 4, 2022 •

edited

changeset-bot bot commented Jun 4, 2022 •

edited

github-actions bot commented Jun 4, 2022 •

edited