Implement `lit init element` #3248

e111077 · 2022-08-26T01:42:11Z

implements lit init element
- flags:
  - --name
    - name of the element
    - defaults to my-element
  - --lang
    - language to use of js or ts
    - defaults to js
implements lit init
- invokes lit init element with default values
changes related to testing
- lit-cli
  - exposes cwd readonly prop
  - run method will await command runs because it was causing some race conditions in the tests
- test-goldens
  - directory holds the goldens to the init tests

changeset-bot · 2022-08-26T01:42:14Z

🦋 Changeset detected

Latest commit: 9d2c39a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@lit-labs/cli	Minor
@lit-labs/gen-utils	Minor
@lit-labs/gen-manifest	Patch
@lit-labs/gen-wrapper-angular	Patch
@lit-labs/gen-wrapper-react	Patch
@lit-labs/gen-wrapper-vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-08-26T01:42:41Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -3% - +1% (-0.61ms - +0.32ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 81.09ms - 86.00ms
lit-html-kitchen-sink: unsure 🔍 -6% - +0% (-1.83ms - +0.09ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +2% (-0.14ms - +0.21ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +2% (-1.27ms - +1.15ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +4% (-1.20ms - +2.15ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 771.39ms - 786.09ms
lit-html-kitchen-sink: unsure 🔍 -5% - +2% (-3.98ms - +1.66ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +1% (-3.56ms - +4.52ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +1% (-2.10ms - +1.14ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-8.88ms - +6.67ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 777.74ms - 789.75ms
reactive-element-list: unsure 🔍 -1% - +2% (-4.43ms - +18.05ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 107.0.5304.87
Sample size: 50
Built by: Benchmarks #4054
Commit: f3180ed

render

Version	Avg time	vs
	81.09ms - 86.00ms	-

update

Version	Avg time	vs
	771.39ms - 786.09ms	-

update-reflect

Version	Avg time	vs
	777.74ms - 789.75ms	-

lit-html-kitchen-sink

Browser: chrome-headless 107.0.5304.87
Sample size: 30
Built by: Benchmarks #4054
Commit: f3180ed

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.90ms - 31.01ms	-	unsure 🔍 -6% - +0% -1.83ms - +0.09ms	unsure 🔍 -5% - +1% -1.70ms - +0.25ms
tip-of-tree tip-of-tree	30.54ms - 32.11ms	unsure 🔍 -0% - +6% -0.09ms - +1.83ms	-	unsure 🔍 -3% - +4% -0.98ms - +1.26ms
previous-release previous-release	30.38ms - 31.99ms	unsure 🔍 -1% - +6% -0.25ms - +1.70ms	unsure 🔍 -4% - +3% -1.26ms - +0.98ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	83.60ms - 86.26ms	-	unsure 🔍 -5% - +2% -3.98ms - +1.66ms	unsure 🔍 -2% - +4% -1.35ms - +3.16ms
tip-of-tree tip-of-tree	83.60ms - 88.58ms	unsure 🔍 -2% - +5% -1.66ms - +3.98ms	-	unsure 🔍 -1% - +6% -1.02ms - +5.15ms
previous-release previous-release	82.20ms - 85.84ms	unsure 🔍 -4% - +2% -3.16ms - +1.35ms	unsure 🔍 -6% - +1% -5.15ms - +1.02ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	22.72ms - 23.21ms	-	unsure 🔍 -3% - +1% -0.61ms - +0.32ms	unsure 🔍 -1% - +2% -0.29ms - +0.40ms
tip-of-tree tip-of-tree	22.71ms - 23.50ms	unsure 🔍 -1% - +3% -0.32ms - +0.61ms	-	unsure 🔍 -1% - +3% -0.26ms - +0.66ms
previous-release previous-release	22.66ms - 23.15ms	unsure 🔍 -2% - +1% -0.40ms - +0.29ms	unsure 🔍 -3% - +1% -0.66ms - +0.26ms	-

lit-html-repeat

Browser: chrome-headless 107.0.5304.87
Sample size: 30
Built by: Benchmarks #4054
Commit: f3180ed

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.45ms - 10.71ms	-	unsure 🔍 -1% - +2% -0.14ms - +0.21ms	unsure 🔍 -1% - +2% -0.13ms - +0.21ms
tip-of-tree tip-of-tree	10.42ms - 10.67ms	unsure 🔍 -2% - +1% -0.21ms - +0.14ms	-	unsure 🔍 -2% - +2% -0.16ms - +0.18ms
previous-release previous-release	10.42ms - 10.66ms	unsure 🔍 -2% - +1% -0.21ms - +0.13ms	unsure 🔍 -2% - +2% -0.18ms - +0.16ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	302.44ms - 308.75ms	-	unsure 🔍 -1% - +1% -3.56ms - +4.52ms	unsure 🔍 -2% - +1% -5.66ms - +2.94ms
tip-of-tree tip-of-tree	302.60ms - 307.63ms	unsure 🔍 -1% - +1% -4.52ms - +3.56ms	-	unsure 🔍 -2% - +1% -5.69ms - +2.02ms
previous-release previous-release	304.03ms - 309.87ms	unsure 🔍 -1% - +2% -2.94ms - +5.66ms	unsure 🔍 -1% - +2% -2.02ms - +5.69ms	-

lit-html-template-heavy

Browser: chrome-headless 107.0.5304.87
Sample size: 50
Built by: Benchmarks #4054
Commit: f3180ed

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	54.44ms - 55.98ms	-	unsure 🔍 -2% - +2% -1.27ms - +1.15ms	unsure 🔍 -2% - +2% -1.09ms - +0.94ms
tip-of-tree tip-of-tree	54.34ms - 56.20ms	unsure 🔍 -2% - +2% -1.15ms - +1.27ms	-	unsure 🔍 -2% - +2% -1.16ms - +1.12ms
previous-release previous-release	54.62ms - 55.95ms	unsure 🔍 -2% - +2% -0.94ms - +1.09ms	unsure 🔍 -2% - +2% -1.12ms - +1.16ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	111.37ms - 113.55ms	-	unsure 🔍 -2% - +1% -2.10ms - +1.14ms	unsure 🔍 -1% - +1% -1.42ms - +1.35ms
tip-of-tree tip-of-tree	111.75ms - 114.15ms	unsure 🔍 -1% - +2% -1.14ms - +2.10ms	-	unsure 🔍 -1% - +2% -1.03ms - +1.92ms
previous-release previous-release	111.65ms - 113.35ms	unsure 🔍 -1% - +1% -1.35ms - +1.42ms	unsure 🔍 -2% - +1% -1.92ms - +1.03ms	-

reactive-element-list

Browser: chrome-headless 107.0.5304.87
Sample size: 50
Built by: Benchmarks #4054
Commit: f3180ed

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	54.97ms - 57.71ms	-	unsure 🔍 -2% - +4% -1.20ms - +2.15ms	unsure 🔍 -3% - +5% -1.57ms - +2.75ms
tip-of-tree tip-of-tree	54.91ms - 56.82ms	unsure 🔍 -4% - +2% -2.15ms - +1.20ms	-	unsure 🔍 -3% - +4% -1.81ms - +2.03ms
previous-release previous-release	54.09ms - 57.42ms	unsure 🔍 -5% - +3% -2.75ms - +1.57ms	unsure 🔍 -4% - +3% -2.03ms - +1.81ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	795.69ms - 804.98ms	-	unsure 🔍 -1% - +1% -8.88ms - +6.67ms	unsure 🔍 -2% - +0% -14.80ms - +2.89ms
tip-of-tree tip-of-tree	795.21ms - 807.68ms	unsure 🔍 -1% - +1% -6.67ms - +8.88ms	-	unsure 🔍 -2% - +1% -14.62ms - +4.93ms
previous-release previous-release	798.76ms - 813.81ms	unsure 🔍 -0% - +2% -2.89ms - +14.80ms	unsure 🔍 -1% - +2% -4.93ms - +14.62ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	817.19ms - 836.99ms	-	unsure 🔍 -1% - +2% -4.43ms - +18.05ms	unsure 🔍 -1% - +2% -6.66ms - +17.74ms
tip-of-tree tip-of-tree	814.95ms - 825.61ms	unsure 🔍 -2% - +1% -18.05ms - +4.43ms	-	unsure 🔍 -1% - +1% -10.17ms - +7.63ms
previous-release previous-release	814.42ms - 828.68ms	unsure 🔍 -2% - +1% -17.74ms - +6.66ms	unsure 🔍 -1% - +1% -7.63ms - +10.17ms	-

_{tachometer-reporter-action v2 for Benchmarks}

e111077 · 2022-08-26T07:34:34Z

cc @augustjk

rodydavis · 2022-08-26T21:50:53Z

Is there an option to init a project too? (Like with init in vite for lit)

e111077 · 2022-08-26T21:51:58Z

Starting off with the MVP that the entire team could agree on. Lots of discussion on simply what should go in the basic element

e111077 · 2022-08-30T20:59:38Z

Ping on review

e111077 · 2022-09-13T22:03:20Z

@justinfagnani requested ping

packages/labs/cli/src/lib/commands/init.ts

packages/labs/cli/src/lib/init/element-starter/index.ts

packages/labs/cli/src/lib/init/element-starter/templates/gitignore.ts

packages/labs/cli/src/lib/init/element-starter/templates/index.html.ts

packages/labs/cli/src/lib/init/element-starter/templates/lib/element.ts

packages/labs/cli/src/lib/init/element-starter/templates/package.json.ts

justinfagnani · 2022-09-22T01:25:47Z

packages/labs/cli/src/lib/init/element-starter/templates/package.json.ts

+    "typescript": "^4.7.4"`
+    }
+  },
+  "exports": {


I think we'll want a files field too.

Isn't .npmignore a more common thing? People new to Lit may come along and do npx lit init and then see that there is no .npmignore and then add one. Then if they add a top-level index.js or something they will be confused why it's not being published.

I don't know what's more common, we usually use files because it's opt-in vs opt-out.

Huh, I didn't realize you could effectively choose files to publish via .npmignore vs. files. I guess I'm most familiar with files because that's what we've always used.

There's at least one guy on the internet that strongly agrees with Justin:
https://medium.com/@jdxcode/for-the-love-of-god-dont-use-npmignore-f93c08909d8d

The npm blog also recommends files vs. .npmignore:
https://blog.npmjs.org/post/165769683050/publishing-what-you-mean-to-publish

packages/labs/cli/src/lib/init/element-starter/templates/package.json.ts

packages/labs/cli/src/lib/init/element-starter/templates/lib/element.ts

packages/labs/cli/src/lib/init/element-starter/templates/gitignore.ts

packages/labs/cli/src/lib/init/element-starter/templates/lib/element.ts

packages/labs/cli/src/lib/init/element-starter/templates/package.json.ts

sorvell

Consider optimizing for the amount of work a user has to do to customize the component, i.e. removing everything but the render method.

packages/labs/cli/src/lib/init/element-starter/templates/index.html.ts

packages/labs/cli/src/lib/init/element-starter/templates/lib/element.ts

Co-authored-by: Justin Fagnani <justinfagnani@google.com>

e111077 · 2022-10-06T14:40:11Z

ping @justinfagnani

justinfagnani

LGTM!

The static properties comment is the only one I'd require before merging. If you want we can chat output file layout and the lib directory.

packages/labs/cli/src/lib/init/element-starter/templates/lib/element.ts

packages/labs/cli/src/lib/init/element-starter/templates/tsconfig.json.ts

kevinpschaaf · 2022-11-14T23:18:17Z

packages/labs/cli/src/lib/commands/init.ts

+              'Tag name of the Element to generate (must include a hyphen).',
+          },
+          {
+            name: 'dir',


In the gen command, we currently call this out, and all things equal would be nice to have common naming for common things between commands. Let's change one or the other to be common.

lit/packages/labs/cli/src/lib/commands/labs.ts

Lines 34 to 38 in cce4629

{

name: 'out',

defaultValue: './gen',

description: 'Folder to output generated packages to.',

},

I don't love out, but since gen also has an input directory (package), dir is probably too ambiguous.

will follow up with another PR rn

kevinpschaaf · 2022-11-14T23:24:16Z

packages/labs/cli/src/lib/init/element-starter/templates/lib/element.ts

+      [`${elementName}.${language}`]:
+        language === 'js'
+          ? generateTemplate(elementName, language)
+          : generateTemplate(elementName, language),


I think you can get rid of the ternary now?

kevinpschaaf · 2022-11-14T23:59:36Z

packages/labs/cli/src/lib/init/element-starter/templates/package.json.ts

+    "typescript": "^4.7.4"`
+    }
+  },
+  "exports": {


Huh, I didn't realize you could effectively choose files to publish via .npmignore vs. files. I guess I'm most familiar with files because that's what we've always used.

There's at least one guy on the internet that strongly agrees with Justin:
https://medium.com/@jdxcode/for-the-love-of-god-dont-use-npmignore-f93c08909d8d

The npm blog also recommends files vs. .npmignore:
https://blog.npmjs.org/post/165769683050/publishing-what-you-mean-to-publish

* Move the render function to the end of lit-html (#3284) * Move the render function to the end of lit-html Believe it or not, this is part of some work to better integrate with closure compiler's dead code elimination. * Add an empty changeset. * Fix empty changeset. * Task: Do not reset task value or error on pending (#3283) * [infra] Enable IntersectionController and PerformanceController tests (#3291) Add intersection controller and performance controller tests to CI - skipping Safari. Deflake Firefox intersection controller tests. * [labs/ssr] fix Hydrating LitElements example markup (#3298) * [labs/observers] Fix controllers not observing target if initialized after host connected (#3293) Co-authored-by: Steve Orvell <sorvell@google.com> * [labs/analyzer] Refactor Analyzer into better fit for use in plugins (#3288) * Refactor context * Make Analyzer implement AnalyzerInterface rather than has-a AnalyzerContext * Add PackageInfo and pass to getModule * Add changeset. Minor cleanup. * Fix cli test * Normalize rootDir * Refactor PackageAnalyzer into factory * Address feedback. Minor cleanup. * Slack -> Discord readme (#3307) * [@labs/gen-wrapper-react] TestOutput links to monorepo for dependencies (#3310) * test-output points to the same react dependency * remove types from tsconfig in labs_react * restore multiple react versions * [labs/cli] Lazily install and locally version localize (#2936) * [cli] Lazily install and locally version localize Also merge the two localize commands into one They have just about the same deps and share some setup and teardown code, there's no win in putting them in separate modules. * Use better assertions of no errors. This should print out the stderr output in the case there was some. * Fix error output The .finally fork of the Promise.race result promise was causing an early exit from node before the ordinary uvu error handling could kick in. * Fix failing test It was passing locally because the cwd was set to the CLI directory, but we want to run in a fake workspace directory. * Add an installation message when running npm install. * Changeset * Use try/finally instead of promise methods * Move localize command into its own package. * Task add onComplete and onError (#3287) * [lit] Add "types" to package exports (#3320) * [lit-html] Add `isServer` environment checker module (#3318) Adds an `isServer` variable export to `lit` and `lit-html/is-server.js` which will be `true` in Node and `false` in the browser. This can be used when authoring components to change behavior based on whether or not the component is executing in an SSR context. * [labs/analyzer] Adds support for analyzing JavaScript packages (#3304) * Add support for analyzing JavaScript packages * Fix customElements.define detection, add comments. * Better comments / error handling * Revert accidental SSR changes * Add optional/non-null to model * Run analyzer_test in JS. Add changeset. * Fix gen-wrapper-angular * Fix another inadvertant SSR change * Address review feedback. * Add test based on feedback. * [labs/observers] Improve controllers value type from unknown to generic (#3294) Fix value property of type `unknown` on exported controllers. The type of `value` is now generic and can be inferred from the return type of your passed in `callback`. The default callback `() => true` was removed, and is now undefined by default. * [labs/react] Provide explicit return type from createComponent (#3163) * create params object * add changeset * update readme * eeek, this requires generics * found correct return type * more refined type * add ref typing * adjust ref typings * type forwarded instance * expose types at top of file * organize types * no react window module * no react window module * add event listeners * checkout readmes from main * remove as casting in render * remove anys * create minimal JSXInterface for library * save types * jsxmodule * attrubtes over htmlprops * explicit return of element types * move comments * minimal references to window * remove ref cast * remove code changes, type only changes * update changeset * ideal * roll back to minimal amount of changes * types at top of file * better comment * rename userprops to element props * add types to test refs * add extends to exported element props type * pause to sync * add comments, more specific names for events * update EventNames downstream * include package types in tsconfig * undo * tests pass with no extra exports * exposing element props successful * wow only the exposed ReactWebComponent fails * add react types to workspaces * move types to dev deps * remove artifacts from different PR * remove rollup artifact from other PR * declare types in test-output tsconfig * capitals for classes * add export to ReactWebComponent * a/b the types array in test-output * add test for ReactWebComponent type * simplify test * componentProps to ReactComponentProps * type only test * update description * unblocked gen-wrapper-react * add comment for type test * restore modified files * restore modified files, again * remove types tsconfig property * only export what's required * remove old code * add return type * remove extra line in index * [labs/observers] observed targets are re-observed when the host is reconnected (#3321) Controllers now track all observed targets and will restore observing targets when host is reconnected. Fixes: #2902 * [labs/observers] Add unobserve method to ResizeController and IntersectionController (#3323) Add unobserve method to `ResizeController` and `IntersectionController` to match native API. Fixes: #3237 * [labs/gen-utils] Add core packages to testing install with link (#3330) * [infra] Update changesets and package for release (#3332) * Update changesets for release * Update cli-localize package.json for release * Add @lit-labs/cli-localize to changeset * Remove gen-wrapper-angular from changesets (#3336) * Version Packages (#3337) * Unpin Node version for windows-tools test (#3338) * [labs/react] introduce a options object (#2988) * create params object * add changeset * update readme * eeek, this requires generics * found correct return type * more refined type * add ref typing * adjust ref typings * type forwarded instance * expose types at top of file * organize types * no react window module * no react window module * more merge main * initial params bag * add changeset, remove commented code * ReactOrParams * destructure params * update tests, react is optional * remove optional react * remove default react * change is a patch * forgot options.react * [labs/react] Update REAMDE for function overload (#3350) * initial commit * add empty changeset * [@lit-labs/router] add Routes.link tests (#3348) * [gen-manifest] Initial impl of CEM generator (#2990) * [gen-manifest] Initial impl of CEM generator Reset changelog Fix readme * Sync with monorepo changes * Fix comments * Add variable declaration * Update to changes on main. * Fix version for gen-utils * Fix analyzer version * Fix and add tests for type reference serialization * [labs/analyzer] Cache Module models based on dependencies. (#3333) * Cache Module models based on dependencies. * Cleanup and add changeset. * Windows path fixes * Normalize all the paths for Windows * Move moduleCache from module var to Analyzer field. * Add missing wireit input * Add missing wireit output * Fix typo in task README (#3385) * Initializers are copied but separate from superclass initializers (#3374) Initializers are copied but separate from superclass initializers, fixes #/3373. * Example code had an h1 tag closed by an h3 tag (#3392) I changed the h3 tag to be an h1 tag to match the other routes * Improvements to Vue/React wrappers (#3377) Updates react wrapper to correctly type events Update vue wrapper * update vite/vue deps * properly type events * configure defaults using the Vue convention: whenever unset, revert to default value. * Wrapper test elements + runtime tests (#3384) * Adds additional test elements * element-events: for testing events * element-props: for testing property types * element-slots: for testing slotting. * Adds property types to angular wrapper * [@labs/react] certain attributes should be removed when undefined or null (#3128) * add sieve for boolean attributes * unchange stuff that isn't required yet * add changeset * no sieve, use hasAttribute * use hasOwnProperty * boolean attributes should test as null * pause * let react handle the nullifies * remove unnecessary return * add comment, update changeset * remove 232 * cascade logic over nested * update comments * don't watch for disabled * show test updates and output * hidden attr is alright * passing tests * set HTMLPrototype undefined values to empty string * id is the special case * add tests for properties * update tests for properties * remove nested iffs from set property * format * set as empty string * change value, don't assign * value as str * remove attribute if undefined * set value as string on htmlelement attr * match vanilla react behavior * order ifs by cost, comment alternatives * forgot return * checkpoint * sync with example gist * draggable is null * checkpoint * update tests, wrappedEl vs el * test div against web component * remove extra lines * update changeset * include unwrapped web component x-foo * add null checks at end of attribute checks * add comments, add undefined tests after boolean * typo, enumerated * add null checkes to test, add ts-expect-errors * add test ordering * forgot one truthy test * [infra] Use new projectV2 object in issue workflow (#3419) * Add lit to changeset along side reactive-element (#3422) * Version Packages (#3423) * Update chromedriver to 107 for benchmark tests (#3427) * Update chromedriver to 107 for benchmark tests * [labs/virtualizer] Fix width inheritance calculation (issue #3400) (#3424) * Added a test to demonstrate virtualizer width inheritance bug in #3400 * Applied the fix to Virtualizer _updateView to interpret width correctly. * Added changeset describing the fix for #3400. * [labs/virtualizer] Export event classes through a new events.js (#3430) * Added an events.js to export the RangeChangedEvent and VisibilityChangedEvent classes. * Point to events.js to get the event classes now and moved the custom Range interface into there. * Added events.js files to package.json's files property and the wireit outputs for build:ts. * [labs/context] Rename context decorators to consume and provide (#3398) * [@labs/react] Filter __forwardedRef in prod build (#3409) * [labs/react] Filter __forwardedRef in prod build * rebased from main, branched from react-forwarded-ref * added changeset * update ref setting * add dunders back in * add comments, update changeset * iterrate userprops Co-authored-by: Justin Fagnani <justinfagnani@google.com> * [labs/context] Make @consume decorator work with optional fields (#3399) * [labs/context] Rename ContextKey to Context (#3404) * Allow ContextProvider to be added lazily and still work with ContextRoot (#3434) * [infra] Fix npm install with version 9 (#3448) * Fix dep on missing folder. Fixes npm install on npm 9. * Add empty changeset * Implement `lit init element` (#3248) Co-authored-by: Justin Fagnani <justinfagnani@google.com> * Logo dark mode support (#3457) * Update logo.svg * empty changeset * lit logo dark mode * add light theme too * fix file locations * use srcset * slack to discord badge * Gitignore build output files from virtualizer (#3454) * Gitignore build output files from virtualizer * add prettierignore files * [labs/analyzer] Add lazy Declaration analysis, Reference dereferencing, and Superclass support (#3380) * Fix comment * Use NODE_OPTIONS=--enable-source-maps * Make declarations lazy * Analyze exports and add ability to dereference References to them * Add superClass reference analysis * Add changeset * fixup! Use NODE_OPTIONS=--enable-source-maps * Fix references to ImportTypes * Add CEM generation to CLI * Fix type import references * Address review feedback. * Fix path normalization on Windows * Updates based on feedback. * Add getSpecifierString to another site. * [labs/gen-manifest] Adds `exports` and more metadata to manifest generator (#3464) * Adds exports to manifest generator Also fixes a few bugs in export analysis and adds better tests. * Add `@slot`, `@cssProp`, and `@cssPart` to manifest generator * Fix config to make JS program analysis faster. * Add windows line ending to regex * Add changeset * Additional Windows line endings fix. * Add support for parsing description, summary, & deprecated * Add more exports support * Emit summary & description in manifest. * Gitignore build output files from virtualizer (#3454) * Gitignore build output files from virtualizer * add prettierignore files * Add the js.map extension to the files property for events.js. * update .prettierignore and .gitignore to include events.js.map Co-authored-by: Peter Burns <rictic@google.com> Co-authored-by: Elliott Marquez <5981958+e111077@users.noreply.github.com> Co-authored-by: Andrew Jakubowicz <ajakubowicz@google.com> Co-authored-by: Michael Potter <mgp140@gmail.com> Co-authored-by: Steve Orvell <sorvell@google.com> Co-authored-by: Kevin Schaaf <kschaaf@google.com> Co-authored-by: Brian Taylor Vann <brian.t.vann@gmail.com> Co-authored-by: Augustine Kim <augustinekim@google.com> Co-authored-by: Lit Robot <98060554+lit-robot@users.noreply.github.com> Co-authored-by: Nick Cipriani <nick.cipriani@gmail.com> Co-authored-by: Brendan Baldwin <brendan@usergenic.com> Co-authored-by: Justin Fagnani <justinfagnani@google.com>

e111077 added 3 commits August 25, 2022 18:29

Implement lit init element

75a0012

fix issue with formatting

519ea7b

ignore goldens from formatting

ba50f93

e111077 added 3 commits August 25, 2022 18:44

el chango setto

bfeb778

do not gitignore the lib in js

98bfb81

await run results in lit-cli

37ae131

e111077 force-pushed the gen-min-element-starter branch from 89f41fa to 37ae131 Compare August 26, 2022 07:22

prettier ignore test goldens

26a1e8b

e111077 marked this pull request as ready for review August 26, 2022 07:34

e111077 requested a review from justinfagnani as a code owner August 26, 2022 07:34

e111077 requested review from rictic and kevinpschaaf August 26, 2022 07:34

justinfagnani reviewed Sep 21, 2022

View reviewed changes

justinfagnani requested changes Sep 22, 2022

View reviewed changes

kevinpschaaf reviewed Sep 22, 2022

View reviewed changes

sorvell requested changes Sep 23, 2022

View reviewed changes

e111077 and others added 3 commits September 22, 2022 18:25

Update packages/labs/cli/src/lib/commands/init.ts

815716b

Co-authored-by: Justin Fagnani <justinfagnani@google.com>

implement review suggestions

2a2e318

update prettierignore for cli

faa832d

e111077 requested review from justinfagnani, kevinpschaaf and sorvell September 24, 2022 00:04

justinfagnani approved these changes Nov 11, 2022

View reviewed changes

e111077 added 3 commits November 14, 2022 14:57

Merge branch 'main' into gen-min-element-starter

129c364

update prettierignore

c5906b3

remove overrides and use static members

9d2c39a

e111077 enabled auto-merge (squash) November 14, 2022 23:19

e111077 disabled auto-merge November 14, 2022 23:19

sorvell approved these changes Nov 14, 2022

View reviewed changes

e111077 merged commit 9b9bdb0 into main Nov 14, 2022

e111077 deleted the gen-min-element-starter branch November 14, 2022 23:26

kevinpschaaf reviewed Nov 15, 2022

View reviewed changes

e111077 mentioned this pull request Nov 15, 2022

[CLI] lit init address remaining suggestions #3456

Merged

This was referenced Dec 7, 2022

Version Packages #3504

Closed

Version Packages #3506

Merged

	{
	name: 'out',
	defaultValue: './gen',
	description: 'Folder to output generated packages to.',
	},

Implement lit init element #3248

Implement lit init element #3248

Conversation

e111077 commented Aug 26, 2022 • edited

changeset-bot bot commented Aug 26, 2022 • edited

🦋 Changeset detected

github-actions bot commented Aug 26, 2022 • edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

e111077 commented Aug 26, 2022

rodydavis commented Aug 26, 2022

e111077 commented Aug 26, 2022

e111077 commented Aug 30, 2022

e111077 commented Sep 13, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sorvell left a comment

Choose a reason for hiding this comment

e111077 commented Oct 6, 2022

justinfagnani left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Implement `lit init element` #3248

Implement `lit init element` #3248

e111077 commented Aug 26, 2022 •

edited

changeset-bot bot commented Aug 26, 2022 •

edited

github-actions bot commented Aug 26, 2022 •

edited