Lit 3.0 branch #3752

justinfagnani · 2023-03-23T21:13:20Z

This is a draft PR that exists just to easily view build status, diffs, and keep GitHub from continuously suggesting that we make a PR for the 3.0 branch.

changeset-bot · 2023-03-23T21:13:24Z

🦋 Changeset detected

Latest commit: 228ae0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/compiler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-03-23T21:13:44Z

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

nop-update

⏱ lit-html-kitchen-sink: unsure 🔍 -16% - +10% (-3.86ms - +2.47ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 98.01ms - 103.21ms
⏱ lit-html-kitchen-sink: unsure 🔍 -9% - +6% (-4.43ms - +2.71ms)
^{this-change vs tip-of-tree}
⏱ lit-html-repeat: unsure 🔍 -5% - +22% (-0.71ms - +2.99ms)
^{this-change vs tip-of-tree}
⏱ lit-html-template-heavy: unsure 🔍 -5% - +1% (-3.31ms - +0.98ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -4% - +2% (-2.80ms - +1.15ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 1113.71ms - 1132.04ms
⏱ lit-html-kitchen-sink: unsure 🔍 -10% - +4% (-12.03ms - +4.52ms)
^{this-change vs tip-of-tree}
⏱ lit-html-repeat: unsure 🔍 -3% - +3% (-9.31ms - +8.79ms)
^{this-change vs tip-of-tree}
⏱ lit-html-template-heavy: unsure 🔍 -2% - +3% (-3.66ms - +4.63ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-15.49ms - +16.02ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 1084.56ms - 1101.69ms
reactive-element-list: unsure 🔍 -2% - +1% (-20.18ms - +10.31ms)
^{this-change vs tip-of-tree}

Results

⏳ Benchmarks are currently running. Results below are out of date.

lit-element-list

Browser: chrome-headless 112.0.5615.121
Sample size: 50
Built by: Benchmarks #4676
Commit: 5f139fc

render

Version	Avg time	vs
	98.01ms - 103.21ms	-

update

Version	Avg time	vs
	1113.71ms - 1132.04ms	-

update-reflect

Version	Avg time	vs
	1084.56ms - 1101.69ms	-

⏱ lit-html-kitchen-sink

Browser: chrome-headless 112.0.5615.121
Sample size: 30
Built by: Benchmarks #4676
Commit: 5f139fc

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	45.33ms - 50.21ms	-	unsure 🔍 -9% - +6% -4.43ms - +2.71ms	unsure 🔍 -6% - +11% -2.51ms - +4.93ms
tip-of-tree tip-of-tree	46.02ms - 51.24ms	unsure 🔍 -6% - +9% -2.71ms - +4.43ms	-	unsure 🔍 -4% - +13% -1.77ms - +5.90ms
previous-release previous-release	43.76ms - 49.37ms	unsure 🔍 -10% - +5% -4.93ms - +2.51ms	unsure 🔍 -12% - +3% -5.90ms - +1.77ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	107.88ms - 118.76ms	-	unsure 🔍 -10% - +4% -12.03ms - +4.52ms	unsure 🔍 -8% - +6% -9.77ms - +7.28ms
tip-of-tree tip-of-tree	110.85ms - 123.31ms	unsure 🔍 -4% - +11% -4.52ms - +12.03ms	-	unsure 🔍 -6% - +10% -6.54ms - +11.56ms
previous-release previous-release	108.01ms - 121.13ms	unsure 🔍 -6% - +9% -7.28ms - +9.77ms	unsure 🔍 -10% - +6% -11.56ms - +6.54ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	20.51ms - 25.25ms	-	unsure 🔍 -16% - +10% -3.86ms - +2.47ms	unsure 🔍 -12% - +16% -2.56ms - +3.56ms
tip-of-tree tip-of-tree	21.48ms - 25.67ms	unsure 🔍 -11% - +17% -2.47ms - +3.86ms	-	unsure 🔍 -8% - +18% -1.66ms - +4.05ms
previous-release previous-release	20.44ms - 24.31ms	unsure 🔍 -15% - +11% -3.56ms - +2.56ms	unsure 🔍 -17% - +7% -4.05ms - +1.66ms	-

⏱ lit-html-repeat

Browser: chrome-headless 112.0.5615.121
Sample size: 30
Built by: Benchmarks #4676
Commit: 5f139fc

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.11ms - 16.67ms	-	unsure 🔍 -5% - +22% -0.71ms - +2.99ms	unsure 🔍 -6% - +20% -0.78ms - +2.84ms
tip-of-tree tip-of-tree	13.23ms - 14.27ms	unsure 🔍 -19% - +4% -2.99ms - +0.71ms	-	unsure 🔍 -5% - +4% -0.74ms - +0.51ms
previous-release previous-release	13.52ms - 14.20ms	unsure 🔍 -18% - +4% -2.84ms - +0.78ms	unsure 🔍 -4% - +5% -0.51ms - +0.74ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	337.52ms - 350.20ms	-	unsure 🔍 -3% - +3% -9.31ms - +8.79ms	unsure 🔍 -3% - +2% -10.02ms - +7.45ms
tip-of-tree tip-of-tree	337.66ms - 350.58ms	unsure 🔍 -3% - +3% -8.79ms - +9.31ms	-	unsure 🔍 -3% - +2% -9.86ms - +7.80ms
previous-release previous-release	339.13ms - 351.16ms	unsure 🔍 -2% - +3% -7.45ms - +10.02ms	unsure 🔍 -2% - +3% -7.80ms - +9.86ms	-

⏱ lit-html-template-heavy

Browser: chrome-headless 112.0.5615.121
Sample size: 50
Built by: Benchmarks #4676
Commit: 5f139fc

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	70.29ms - 73.82ms	-	unsure 🔍 -5% - +1% -3.31ms - +0.98ms	unsure 🔍 -2% - +4% -1.50ms - +2.85ms
tip-of-tree tip-of-tree	72.00ms - 74.44ms	unsure 🔍 -1% - +5% -0.98ms - +3.31ms	-	slower ❌ 0% - 5% 0.07ms - 3.61ms
previous-release previous-release	70.10ms - 72.66ms	unsure 🔍 -4% - +2% -2.85ms - +1.50ms	faster ✔ 0% - 5% 0.07ms - 3.61ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	148.68ms - 153.86ms	-	unsure 🔍 -2% - +3% -3.66ms - +4.63ms	unsure 🔍 -3% - +2% -5.32ms - +2.92ms
tip-of-tree tip-of-tree	147.54ms - 154.02ms	unsure 🔍 -3% - +2% -4.63ms - +3.66ms	-	unsure 🔍 -4% - +2% -6.25ms - +2.87ms
previous-release previous-release	149.27ms - 155.68ms	unsure 🔍 -2% - +4% -2.92ms - +5.32ms	unsure 🔍 -2% - +4% -2.87ms - +6.25ms	-

reactive-element-list

Browser: chrome-headless 112.0.5615.121
Sample size: 50
Built by: Benchmarks #4676
Commit: 5f139fc

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	72.05ms - 74.68ms	-	unsure 🔍 -4% - +2% -2.80ms - +1.15ms	unsure 🔍 -7% - +2% -5.13ms - +1.73ms
tip-of-tree tip-of-tree	72.71ms - 75.66ms	unsure 🔍 -2% - +4% -1.15ms - +2.80ms	-	unsure 🔍 -6% - +3% -4.37ms - +2.62ms
previous-release previous-release	71.90ms - 78.23ms	unsure 🔍 -2% - +7% -1.73ms - +5.13ms	unsure 🔍 -4% - +6% -2.62ms - +4.37ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1155.89ms - 1177.26ms	-	unsure 🔍 -1% - +1% -15.49ms - +16.02ms	unsure 🔍 -2% - +0% -29.17ms - +5.05ms
tip-of-tree tip-of-tree	1154.74ms - 1177.89ms	unsure 🔍 -1% - +1% -16.02ms - +15.49ms	-	unsure 🔍 -3% - +0% -30.00ms - +5.36ms
previous-release previous-release	1165.27ms - 1192.00ms	unsure 🔍 -0% - +3% -5.05ms - +29.17ms	unsure 🔍 -0% - +3% -5.36ms - +30.00ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1160.76ms - 1183.83ms	-	unsure 🔍 -2% - +1% -20.18ms - +10.31ms	unsure 🔍 -2% - +1% -19.00ms - +11.39ms
tip-of-tree tip-of-tree	1167.26ms - 1187.20ms	unsure 🔍 -1% - +2% -10.31ms - +20.18ms	-	unsure 🔍 -1% - +1% -12.91ms - +15.17ms
previous-release previous-release	1166.21ms - 1185.98ms	unsure 🔍 -1% - +2% -11.39ms - +19.00ms	unsure 🔍 -1% - +1% -15.17ms - +12.91ms	-

_{tachometer-reporter-action v2 for Benchmarks}

* Remove sauce-ie11 workflow * Remove sauce-ie11 browser preset * Remove ie11 and edge launcher examples in starter kits

* Remove decorators export from lit-element/index.ts * Remove UpdatingElement alias for ReactiveElement

* Remove experimental-hydrate-support from lit-element * Remove expriemental-hydrate from lit-html * Remove re-exports from lit * Remove from node-imports tests

* Coerce toggleAttribute's second arg to boolean Otherwise binding the value `undefined` to a boolean part would mean `toggle` rather than `false` * Add a test for a boolean part with undefined

…te storage. (#3693)

* Use Symbol.for in dev mode This makes it much easier to maintain state for an element during HMR because keys stay the same across different versions of the class.

* First part of conversion to TS 5.0 * Minor fixes * Changeset * Remove unnecessary dep * Fix another compiler error. * Do a breaking change bump to localize-tools and ts-transformers. * Standardize on a single version for @esm-bundle/chai * Uninstall chai

Note: The size bump here is correcting the 3.0 branch. Because merging into 3.0 is not atomic, it's possible that two changes both updated sizes, but no change existed to combine the two changes.

…nalized (#4257) * elementProperties is a static property that's dynamic similarly to finalized To get correct semantics out of it, we need to hide it from closure's instinct to collapse it by using dynamic property access syntax. * Avoid using dynamic property access Also hide the static property initialization from jscompiler, and it won't manually copy those fields down onto subclasses. This is a bit larger for terser, but we expect the code to be faster because we're doing fewer dynamic property accesses, and it's both smaller and faster for jscompiler because it can rename both elementProperties and finalize.

* update goldens * add empty changeset

* Add a missing dependency gen-manifest depends on being able to resolve LitElement types, so it lit-element must build before it does * react:test:dev reads index.js so it depends on build:rollup * Update file reference in @lit-internal/gen-wrapper-vue-test-output * Fix wrapper-react, use more explicit semver ranges * Add another missing dep. * Remove console log * Add missing dev dep, improve wireit dep. * Bump eleventy test timeout This test frequently times out * Run local tests serially to reduce flakiness.

AndrewJakubowicz

Woooooooo! Nice job y'all!

Enter prerelease mode for 3.0 (#3749)

c39d1ba

justinfagnani added the 3.0 label Mar 23, 2023

justinfagnani and others added 26 commits March 24, 2023 12:23

[all] Drop IE11 support (#3756)

f06f797

* Remove sauce-ie11 workflow * Remove sauce-ie11 browser preset * Remove ie11 and edge launcher examples in starter kits

Update lockfile (#3755)

7d49a0f

[lit-html] Simplify lit-html attribute handling (#3751)

dfd747c

Use replaceWith() for SVG templates (#3759)

1db0137

[all] Use globalThis (#3753)

8649cc2

Remove @types/web-ie11 dependency (#3758)

f26de47

Remove Lit 1 -> Lit 2 migration warnings (#3762)

23c404f

Small cleanups to styleMap() and classMap() (#3763)

951eb26

[lit-element] Remove lit-element@2.x back-compat exports (#3754)

76795a1

* Remove decorators export from lit-element/index.ts * Remove UpdatingElement alias for ReactiveElement

Update web components polyfills

8cad094

Use toggleAttribute() in boolean attribute parts

c3e473b

Merge branch 'main' into 3.0

3438cb4

Merge branch 'main' into 3.0

a273eb9

Merge branch 'main' into 3.0

5eb39dc

Merge branch 'main' into 3.0

0f6c92f

[labs/ssr-client] Fix for removing @types/web-ie11 dep (#3779)

5db7efd

[all] Remove experimental hydration modules (#3765)

92cedaa

* Remove experimental-hydrate-support from lit-element * Remove expriemental-hydrate from lit-html * Remove re-exports from lit * Remove from node-imports tests

Coerce toggleAttribute's second arg to boolean (#3799)

01902ef

* Coerce toggleAttribute's second arg to boolean Otherwise binding the value `undefined` to a boolean part would mean `toggle` rather than `false` * Add a test for a boolean part with undefined

Merge branch 'main' into 3.0

5e2195f

Upgrade build targets to ES2021 (#3775)

85ca81a

[reactive-element] Only use symbol keys for properties added as priva…

342b75e

…te storage. (#3693)

Use Symbol.for in dev mode (#3816)

be72f66

* Use Symbol.for in dev mode This makes it much easier to maintain state for an element during HMR because keys stay the same across different versions of the class.

Merge branch 'main' into 3.0

83f05e8

Merge branch 'main' into 3.0

e26adb9

Update readmes for 3.0 (#3836)

9b2659b

[infra] Update gen-wrapper-react golden (#4247)

9769da3

AndrewJakubowicz had a problem deploying to Changesets October 4, 2023 00:01 — with GitHub Actions Failure

[infra] sync 3.0 package-lock after second pre-release (#4255)

c6837ec

Note: The size bump here is correcting the 3.0 branch. Because merging into 3.0 is not atomic, it's possible that two changes both updated sizes, but no change existed to combine the two changes.

AndrewJakubowicz had a problem deploying to Changesets October 4, 2023 00:14 — with GitHub Actions Failure

[infra] Add wireit build dep for labs/react test scripts (#4256)

0f8b266

augustjk had a problem deploying to Changesets October 4, 2023 01:31 — with GitHub Actions Failure

rictic had a problem deploying to Changesets October 5, 2023 21:44 — with GitHub Actions Failure

[infra] update gen-wrapper goldens (#4258)

536753c

* update goldens * add empty changeset

rictic had a problem deploying to Changesets October 5, 2023 21:45 — with GitHub Actions Failure

Gosh, yet more google3 jscompiler comment tweaks. (#4262)

682c436

rictic had a problem deploying to Changesets October 5, 2023 22:42 — with GitHub Actions Failure

rictic had a problem deploying to Changesets October 6, 2023 23:18 — with GitHub Actions Failure

rictic had a problem deploying to Changesets October 6, 2023 23:22 — with GitHub Actions Failure

Merge branch 'main' into 3.0

cb6b507

rictic force-pushed the 3.0 branch from ee4fdf4 to cb6b507 Compare October 6, 2023 23:25

rictic had a problem deploying to Changesets October 6, 2023 23:25 — with GitHub Actions Failure

Add missing dep in transform-ts

58794d4

rictic had a problem deploying to Changesets October 6, 2023 23:41 — with GitHub Actions Failure

Try disabling wireit caching

228ae0f

rictic had a problem deploying to Changesets October 6, 2023 23:54 — with GitHub Actions Failure

rictic changed the title ~~Lit 3.0 Placeholder~~ Lit 3.0! Oct 7, 2023

rictic marked this pull request as ready for review October 7, 2023 01:18

rictic requested review from benjamind and kevinpschaaf as code owners October 7, 2023 01:18

AndrewJakubowicz approved these changes Oct 7, 2023

View reviewed changes

rictic changed the title ~~Lit 3.0!~~ Lit 3.0 branch Oct 9, 2023

rictic merged commit 9f9120f into main Oct 9, 2023
9 of 10 checks passed

rictic deleted the 3.0 branch October 9, 2023 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lit 3.0 branch #3752

Lit 3.0 branch #3752

justinfagnani commented Mar 23, 2023 •

edited

changeset-bot bot commented Mar 23, 2023 •

edited

github-actions bot commented Mar 23, 2023 •

edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

AndrewJakubowicz left a comment •

edited

Lit 3.0 branch #3752

Lit 3.0 branch #3752

Conversation

justinfagnani commented Mar 23, 2023 • edited

changeset-bot bot commented Mar 23, 2023 • edited

🦋 Changeset detected

github-actions bot commented Mar 23, 2023 • edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

AndrewJakubowicz left a comment • edited

Choose a reason for hiding this comment

justinfagnani commented Mar 23, 2023 •

edited

changeset-bot bot commented Mar 23, 2023 •

edited

github-actions bot commented Mar 23, 2023 •

edited

AndrewJakubowicz left a comment •

edited