Enhancement: Replace Starlette Responses #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goldziher
force-pushed
the
replace-response
branch
2 times, most recently
from
563ce24
to
e1d1b7a
Compare
|
This pull request introduces 1 alert when merging 6c39d4e into ac18312 - view on LGTM.com new alerts:
|
Goldziher
force-pushed
the
replace-response
branch
from
4a29613
to
4b9463c
Compare
Goldziher
commented
Oct 21, 2022
Goldziher
commented
Oct 21, 2022
|
This pull request introduces 1 alert when merging 4b9463c into 2e6eb83 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 51cb655 into 2e6eb83 - view on LGTM.com new alerts:
|
Goldziher
requested review from
peterschutt,
cofin,
infohash,
jonadaly,
jtraub,
provinzkraut and
seladb
|
PR is still missing docs and some polishing touches, but it is substantially done and the tests are in place - so its a good time to start reviewing. Please do! |
|
This pull request introduces 1 alert when merging cce7f81 into 2e6eb83 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 3205a60 into 2e6eb83 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 0478d38 into 4ee6f56 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 35b431c into 4ee6f56 - view on LGTM.com new alerts:
|
peterschutt
reviewed
Oct 21, 2022
Goldziher
added
Enhancement
|
So with this PR, instead of using starlette |
that is correct |
|
This pull request introduces 1 alert when merging 1711e21 into aef4b85 - view on LGTM.com new alerts:
|
Co-authored-by: Peter Schutt <peter@topsport.com.au>
Co-authored-by: Peter Schutt <peter@topsport.com.au>
* removed starlette dependency for lifespan events * updated tests * fix async callable * added cookie parser (#645) * added cookie parser * address review comments * Replace get name (#646) * add get_name helper * added helper to handle enum * update enum safeguard * Removed starlette HTTPException as code dependency (#647) * removed starlette HTTPException as code dependency * address review comments
* updated background tasks * updated test and docs * address review comment
Goldziher
force-pushed
the
replace-response
branch
from
d69dd4e
to
ba0fddb
Compare
|
This pull request introduces 1 alert when merging ba0fddb into e58dd11 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 79de83b into e58dd11 - view on LGTM.com new alerts:
|
|
Kudos, SonarCloud Quality Gate passed! |
4 tasks
provinzkraut
added a commit
that referenced
this pull request
Oct 27, 2022
provinzkraut
added a commit
that referenced
this pull request
Oct 27, 2022
* Initial draft for server-side sessions and unified session-middleware interface * Implement SessionMiddleware with backends, basic server-session backends. Integrate backends with existing tests * Initial draft for server-side sessions and unified session-middleware interface * Implement SessionMiddleware with backends, basic server-session backends. Integrate backends with existing tests * Initial draft for server-side sessions and unified session-middleware interface * Implement SessionMiddleware with backends, basic server-session backends. Integrate backends with existing tests * v1.30.0 * docs: add mookrs as a contributor for doc (#637) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Minor code cleanup * Improve SQLAlchemy backend, support sync/async * Improved backwards compatibility, typing and tests * Simplify session backend configuration * Add expiry mechanism to FakeAsyncMemcached, improve typing * Test all session backends * Remove a merge artifact * Remove identity-source support for now * Add docstrings to session backends, improve typing * Minor styling fixes * Add reference docs for session middleware * Fix type annotations * Initial draft for server-side sessions and unified session-middleware interface * Implement SessionMiddleware with backends, basic server-session backends. Integrate backends with existing tests * Initial draft for server-side sessions and unified session-middleware interface * Implement SessionMiddleware with backends, basic server-session backends. Integrate backends with existing tests * Initial draft for server-side sessions and unified session-middleware interface * Implement SessionMiddleware with backends, basic server-session backends. Integrate backends with existing tests * v1.30.0 * docs: add mookrs as a contributor for doc (#637) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Minor code cleanup * Improved backwards compatibility, typing and tests * Test all session backends * Remove a merge artifact * session docs draft * Disable MD052 in markdownlint MD052 messes with mkdocs material's code highlighting * Add aiomcache and redis types to pylint dependencies * Remove `backend` property from BaseBackendConfig. This proved difficult to type correctly, and I was hitting python/mypy#12113 (or some variety), so I removed it for now * Add / update reference and usage documentation + some docstrings for session middleware * Remove unused imports * Move session backend config to the top * Some minor documentation adjustments * Improve docstrings Add missing args and returns, add missing docstrings * Rename SessionBackend > BaseSessionBackend * Add _sync suffix to private synchronous methods * Move all type variables to top of the file * Use explicit "import from" consistently * Make FileStorageMetadataWrapper a NamedTuple * Add `make_filename` option to FileBackendConfig * Move fake_memcached.FakeAsyncMemcached to tests/mocks.py * Implement MemoryBackend using SimpleCacheBackend * Add __slots__ for session middleware * Add support for all session backends to TestClient * Update starlite/middleware/session/sqlalchemy_backend.py Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com> * Update starlite/testing/test_client/client.py Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com> * Update starlite/middleware/session/sqlalchemy_backend.py Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com> * Update starlite/middleware/session/memcached_backend.py Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com> * Update starlite/middleware/session/sqlalchemy_backend.py Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com> * Update starlite/middleware/session/cookie_backend.py Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com> * Update starlite/middleware/session/base.py Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com> * Update starlite/testing/test_client/client.py Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com> * Update starlite/testing/test_client/client.py Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com> * Implement support for session backends in TestClient * Make sqlalchemy session examples "run as-is" * Fix lower-casing of header values. (#693) A bug was introduced as part of #626, that would lower case header values * Remove types-redis * Add middleware bypassing to SessionMiddleware Co-authored-by: Peter Schutt <peter.github@proton.me> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
CONTRIBUTING.md?This PR removes the usage of Starlette based
Responseobjects by introducing our own version - with a compatible API.Relates to #612