Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-side sessions and unified session backends #630

Merged
merged 66 commits into from Oct 27, 2022
Merged

Server-side sessions and unified session backends #630

merged 66 commits into from Oct 27, 2022

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Oct 20, 2022 •
edited

This is a bit WIP. Aims to implement #617

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2022

This pull request introduces 4 alerts when merging f19f9d2 into d11d0fb - view on LGTM.com

new alerts:

  • 3 for Module-level cyclic import
  • 1 for Unused import

@provinzkraut provinzkraut linked an issue Oct 26, 2022 that may be closed by this pull request
Enhancement: Server-side sessions #617
Closed
@provinzkraut provinzkraut marked this pull request as ready for review October 26, 2022 15:43
@provinzkraut provinzkraut changed the title [WIP] Server-side sessions and unified session backends Server-side sessions and unified session backends Oct 26, 2022
Goldziher
Goldziher reviewed Oct 26, 2022
View reviewed changes
Copy link
Contributor

@Goldziher Goldziher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, very impressive. There is still some work to be done.

docs/reference/middleware/session-middleware/1-base-backend.md Show resolved Hide resolved
docs/reference/middleware/session-middleware/1-base-backend.md Outdated Show resolved Hide resolved
docs/usage/7-middleware/3-builtin-middlewares/5-session-middleware.md Outdated Show resolved Hide resolved
docs/usage/7-middleware/3-builtin-middlewares/5-session-middleware.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
starlite/middleware/session/sqlalchemy_backend.py Show resolved Hide resolved
starlite/middleware/session/sqlalchemy_backend.py Outdated Show resolved Hide resolved
starlite/middleware/session/sqlalchemy_backend.py Outdated Show resolved Hide resolved
starlite/testing/test_client.py Outdated Show resolved Hide resolved
tests/fake_memcached.py Outdated Show resolved Hide resolved
@infohash
Copy link
Contributor

infohash commented Oct 26, 2022 •
edited

Is it possible to have an extension API to use client side session as complementary? It will help a lot for extensions that manage user authentication and delegation of authority on APIs.

@provinzkraut
Copy link
Member Author

@infohash

Is it possible to have an extension API to use client side session as complementary? It will help a lot for extensions that manage user authentication and delegation of authority on APIs.

I'm still not entirely sure what you mean by this. How would complementary session backends work API wise? And what would the use case be? If the identity is being managed by a different mechanism, it could effectively also just be an arbitrary storage like redis. So why would one want to use this?

provinzkraut and others added 15 commits October 27, 2022 10:46
@provinzkraut
Initial draft for server-side sessions and unified session-middleware…
9bdf5cd 
… interface
@provinzkraut
Implement SessionMiddleware with backends, basic server-session back…
9441f02 
…ends. Integrate backends with existing tests
@provinzkraut
Initial draft for server-side sessions and unified session-middleware…
e8c3f51 
… interface
@provinzkraut
Implement SessionMiddleware with backends, basic server-session backe…
1b272c8 
…nds. Integrate backends with existing tests
@provinzkraut
Initial draft for server-side sessions and unified session-middleware…
eb269c6 
… interface
@provinzkraut
Implement SessionMiddleware with backends, basic server-session backe…
de14140 
…nds. Integrate backends with existing tests
@peterschutt @provinzkraut
v1.30.0
409407c
@allcontributors @provinzkraut
docs: add mookrs as a contributor for doc (#637)
d00788c 
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@provinzkraut
Minor code cleanup
30472e7
@provinzkraut
Improve SQLAlchemy backend, support sync/async
b3deb50
@provinzkraut
Improved backwards compatibility, typing and tests
8e930df
@provinzkraut
Simplify session backend configuration
39d3d48
@provinzkraut
Add expiry mechanism to FakeAsyncMemcached, improve typing
cc3ca32
@provinzkraut
Test all session backends
d2add5a
@provinzkraut
Remove a merge artifact
1605cc0
provinzkraut and others added 15 commits October 27, 2022 15:39
@provinzkraut @Goldziher
Update starlite/middleware/session/sqlalchemy_backend.py
b14d54a 
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
@provinzkraut @Goldziher
Update starlite/testing/test_client/client.py
13a2f01 
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
@provinzkraut @Goldziher
Update starlite/middleware/session/sqlalchemy_backend.py
dfeba2d 
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
@provinzkraut @Goldziher
Update starlite/middleware/session/memcached_backend.py
0e1200a 
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
@provinzkraut @Goldziher
Update starlite/middleware/session/sqlalchemy_backend.py
95005da 
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
@provinzkraut @Goldziher
Update starlite/middleware/session/cookie_backend.py
7c18646 
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
@provinzkraut @Goldziher
Update starlite/middleware/session/base.py
7290228 
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
@provinzkraut @Goldziher
Update starlite/testing/test_client/client.py
c505a82 
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
@provinzkraut @Goldziher
Update starlite/testing/test_client/client.py
7d5b2c7 
Co-authored-by: Na'aman Hirschfeld <nhirschfeld@gmail.com>
@provinzkraut
Implement support for session backends in TestClient
df1bf95
@provinzkraut
Make sqlalchemy session examples "run as-is"
d650ade
@provinzkraut
Fix lower-casing of header values. (#693)
86e82a8 
A bug was introduced as part of #626, that would lower case header values
@provinzkraut
Remove types-redis
4129602
@provinzkraut
Add middleware bypassing to SessionMiddleware
763edd1
@provinzkraut
Merge branch 'lowercase-header-value' into server-side-sessions
630078b
@provinzkraut provinzkraut merged commit 55d7389 into litestar-org:main Oct 27, 2022
@provinzkraut provinzkraut deleted the server-side-sessions branch October 27, 2022 16:29
provinzkraut added a commit that referenced this pull request Oct 28, 2022
@provinzkraut
Support setting sessions explicit to Empty.
be69985 
This was supported in the previous SessionMiddleware and was erroneously removed in #630. Test have been added.
@provinzkraut provinzkraut mentioned this pull request Oct 28, 2022
Merged
4 tasks
provinzkraut added a commit that referenced this pull request Oct 28, 2022
@provinzkraut
Support setting sessions explicit to Empty. (#697)
aa36e21 
* Support setting sessions explicit to `Empty`.

This was supported in the previous SessionMiddleware and was erroneously removed in #630. Test have been added.
@jtraub jtraub mentioned this pull request Oct 30, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraub jtraub jtraub left review comments

@infohash infohash Awaiting requested review from infohash

@seladb seladb Awaiting requested review from seladb

@cofin cofin Awaiting requested review from cofin

@peterschutt peterschutt Awaiting requested review from peterschutt

@Goldziher Goldziher Awaiting requested review from Goldziher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Server-side sessions
5 participants
@provinzkraut @infohash @jtraub @Goldziher @peterschutt