Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 674 replace starlette middleware types #718

Closed
wants to merge 8 commits into from
Closed

Issue 674 replace starlette middleware types #718

wants to merge 8 commits into from

Conversation

Goldziher
Copy link
Contributor

@Goldziher Goldziher commented Oct 30, 2022 •
edited

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

@Goldziher Goldziher marked this pull request as ready for review October 30, 2022 21:53
jtraub
jtraub reviewed Oct 30, 2022
View reviewed changes
starlite/middleware/authentication.py

from pydantic import BaseConfig, BaseModel

from starlite.connection import ASGIConnection
from starlite.enums import ScopeType
from starlite.middleware.util import should_bypass_middleware
from starlite.middleware.utils import should_bypass_middleware
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should update CSRF middleware as well in this PR. It also relies on exclude opts to skip protection on certain routes.

I think @provinzkraut simply forgot to uppdate it in #630 when he introduced should_bypass_middleware function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, but it should be done in a followup

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I did!

@Goldziher
fix tests
36ad05a
@Goldziher
Merge branch 'issue-674-replace-starlette-middleware-types' of github…
ff0d797 
….com:starlite-api/starlite into issue-674-replace-starlette-middleware-types
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.2% 95.2% Coverage
0.0% 0.0% Duplication

@jtraub jtraub mentioned this pull request Oct 31, 2022
Merged
4 tasks
@Goldziher Goldziher closed this Nov 1, 2022
@Goldziher Goldziher deleted the issue-674-replace-starlette-middleware-types branch November 17, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraub jtraub jtraub left review comments

@peterschutt peterschutt peterschutt left review comments

@provinzkraut provinzkraut provinzkraut approved these changes

@cofin cofin Awaiting requested review from cofin

@infohash infohash Awaiting requested review from infohash

@seladb seladb Awaiting requested review from seladb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Goldziher @jtraub @peterschutt @provinzkraut