-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 674 replace starlette middleware types #718
Conversation
|
||
from pydantic import BaseConfig, BaseModel | ||
|
||
from starlite.connection import ASGIConnection | ||
from starlite.enums import ScopeType | ||
from starlite.middleware.util import should_bypass_middleware | ||
from starlite.middleware.utils import should_bypass_middleware |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should update CSRF middleware as well in this PR. It also relies on exclude opts to skip protection on certain routes.
I think @provinzkraut simply forgot to uppdate it in #630 when he introduced should_bypass_middleware function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, but it should be done in a followup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I did!
….com:starlite-api/starlite into issue-674-replace-starlette-middleware-types
Kudos, SonarCloud Quality Gate passed! |
PR Checklist
CONTRIBUTING.md
?