Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layering for opt dictionary #720

Merged
merged 4 commits into from
Oct 31, 2022
Merged

Layering for opt dictionary #720

merged 4 commits into from
Oct 31, 2022

Conversation

jtraub
Copy link
Contributor

@jtraub jtraub commented Oct 31, 2022

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

Since #718 adds bypassing a middleware based on a flag in opt dictionary of a route handler it makes sense to apply layering for opt too.

peterschutt
peterschutt approved these changes Oct 31, 2022
View reviewed changes
starlite/app.py Outdated Show resolved Hide resolved
starlite/config/app.py Outdated Show resolved Hide resolved
provinzkraut
provinzkraut approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@provinzkraut provinzkraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition! Just some minor cosmetic comments from my side here

docs/usage/2-route-handlers/5-handler-opts.md Outdated Show resolved Hide resolved
@jtraub jtraub merged commit d519077 into litestar-org:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschutt peterschutt peterschutt approved these changes

@provinzkraut provinzkraut provinzkraut approved these changes

@Goldziher Goldziher Goldziher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtraub @peterschutt @provinzkraut @Goldziher