Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin URLs should use admin_url() #29

Closed
siliconforks opened this issue Oct 7, 2023 · 1 comment
Closed

Admin URLs should use admin_url() #29

siliconforks opened this issue Oct 7, 2023 · 1 comment

Comments

@siliconforks
Copy link

This issue is kind of similar to issue #28 in that it will only affect sites where WordPress is installed in a subdirectory (e.g., https://example.com/example/).

In inc/media-sizes-verify.php a URL is hard-coded: <a href="/wp-admin/options-media.php">Review Settings</a>. This link will be broken if WordPress is located in a subdirectory.

It should be <a href="<?php echo esc_url( admin_url( 'options-media.php' ) ); ?>">Review Settings</a>.
jessuppi added a commit that referenced this issue Oct 7, 2023
@jessuppi
Update media-sizes-verify.php
b19a2c4 
Ref: #29
@jessuppi
Copy link
Member

jessuppi commented Oct 7, 2023

Done! Thanks @siliconforks

Ref: b19a2c4

@jessuppi jessuppi closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siliconforks @jessuppi