Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to generate more than one Excel per request #43

Closed
lemoinem opened this issue Jun 21, 2013 · 9 comments
Closed

Impossible to generate more than one Excel per request #43

lemoinem opened this issue Jun 21, 2013 · 9 comments

Comments

@lemoinem
Copy link
Contributor

Hello,

I need to create more than one Excel file in one request (They are then bundled in a .zip which is then sent for download).

Sub-requests are not that cool since I don't need them (plus I'm not sure the container will be re-instantiated even with a sub-request) and short from reinitializing the service myself, it's impossible to generate more than one excel at a time.

If the possibility is here (The services.yml is a bit huge a hard to read to me... I may have missed something) could it be possible to document it please?

Thanks for your help and Kudo for the bundle!

@liuggio
Copy link
Owner

liuggio commented Jun 22, 2013

Mmm I don't get what the problem could be except the memory and time limit, please could explain better the workflow that you have thougth?

@lemoinem
Copy link
Contributor Author

Hum... I don't think there is any problem related to generating several Excels. I just don't see any way to get a new excelObj short of creating them myself (thus bypassing the service and the bundle).

I think having a service playing the role of factory (with a createExcelObj and generateResponse methods, or even returning a proxy wrapper around the excelObj with a getResponse method) will be much easier to use than having to bypass the bundle if I want to generate more than one.

@liuggio
Copy link
Owner

liuggio commented Dec 5, 2013

@lemoinem with the @dev version is it fixed? Have you time to check?

@lemoinem
Copy link
Contributor Author

lemoinem commented Dec 5, 2013

Hum... PR #49 solves part of the problem, but in the end, we still always work on a single ExcelObj and there is still no way to get a new one.

However, building up on it, I think I could now provide a new PR to address specifically the issues of being able to use multiple ExcelObj (simultaneously or not) without having to bypass the service.

If you are interested, I will probably have time to do so next week.

Thanks @liuggio for the poke and @gnat42 for the PR!

@liuggio
Copy link
Owner

liuggio commented Dec 5, 2013

Thanks to you def. yes, I hope to find time to add an integration test and to remove the stremed response in favour of Symfony streamed response. :)

@liuggio
Copy link
Owner

liuggio commented Dec 6, 2013

Done :) both, is all your.

@liuggio
Copy link
Owner

liuggio commented Dec 6, 2013

I'm committing the last modification

@liuggio
Copy link
Owner

liuggio commented Dec 6, 2013

I totally have rewritten the Factory, is now possible to create multiple objects.

@liuggio liuggio closed this as completed Dec 6, 2013
@lemoinem
Copy link
Contributor Author

lemoinem commented Dec 6, 2013

Wow! Great! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants