Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reduce conditionals in AbstractReferenceCountedByteBuf
Motivation: AbstractReferenceCountedByteBuf as independent conditional statements to check the bounds of the retain IllegalReferenceCountException condition. One of the exceptions also uses the incorrect increment. The same fix was done for AbstractReferenceCounted as 01523e7. Modifications: - Combined independent conditional checks into 1 where possible - Correct IllegalReferenceCountException with incorrect increment - Remove the subtract to check for overflow and re-use the addition and check for overflow to remove 1 arithmetic operation (see http://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.18.2) Result: AbstractReferenceCountedByteBuf has less independent branch statements and more correct IllegalReferenceCountException. Compilation size of AbstractReferenceCountedByteBuf.retain() is reduced.
- Loading branch information