Only update attributes that get changed instead of all of them #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when calling #save_draft on an object that is getting updated, it updates all columns no matter if they have changed or not. This only updates the changed columns.
I had run into an issue when a column has a mounted_uploader and an error gets thrown:
TypeError: can't quote ImageUploader. I handle images in a different form not using draftsman so it shouldn't be getting called when updating the record. It would also seem Carrierwave's upgrade to 1.0.0 has broken some stuff which is what is causing the TypeError but that's a separate issue.